Add branches attribute to github_repository#892
Merged
jcudit merged 1 commit intointegrations:mainfrom Sep 22, 2021
Merged
Conversation
a5fdcfa to
648dde7
Compare
648dde7 to
740899b
Compare
jcudit
reviewed
Aug 31, 2021
Contributor
jcudit
left a comment
There was a problem hiding this comment.
Can we get a test added or modified to incorporate the new field? Otherwise looks 👌🏾 with the docs update and implementation!
Contributor
Author
|
@jcudit I've only seen tests around for more advanced stuff like resource modification and nontrivial logic, so I figured we don't normally test simple things like this. I'll have another look though! |
jcudit
approved these changes
Sep 10, 2021
Contributor
jcudit
left a comment
There was a problem hiding this comment.
Looks good after verifying locally:
STATE:
data.github_repository.test:
ID = tf-acc-hgsf1
provider = provider.github
allow_merge_commit = true
allow_rebase_merge = true
allow_squash_merge = true
archived = false
branches.# = 1
branches.0.name = main
branches.0.protected = false
Contributor
Author
|
Thank you for finalising this, I got distracted by other things unfortunately. |
Contributor
|
Is this released? It's in the documentation but I'm getting an error when trying to use it just now (Terraform v1.0.3 and integrations/terraform-provider-github v4.17.0): |
muru
added a commit
to muru/terraform-provider-github
that referenced
this pull request
Oct 28, 2021
In integrations#892, the newly-added `branches` attribute was exported for the data source, but not the resource. This exports `branches` in the resource too.
jcudit
pushed a commit
that referenced
this pull request
Dec 3, 2021
In #892, the newly-added `branches` attribute was exported for the data source, but not the resource. This exports `branches` in the resource too.
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
In integrations#892, the newly-added `branches` attribute was exported for the data source, but not the resource. This exports `branches` in the resource too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #748.
Adding
branchesto both the resource and the data source.