Add support to custom roles#1369
Merged
kfcampbell merged 3 commits intointegrations:mainfrom Nov 28, 2022
Merged
Conversation
Contributor
Author
|
@kfcampbell sorry for the insistence but this is the third PR about this issue, I'm trying to bring forward the work of @joshua-hancox that could potentially close 3 issues with a single PR. |
Contributor
|
@SharpEdgeMarshall thanks for submitting this! It seems reasonable to me. Integration tests are passing where passing on main and failing where failing on main. I'll go ahead and merge this PR and create a release for it soon. Hopefully this can put those issues to bed once and for all! |
kfcampbell
approved these changes
Nov 28, 2022
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
* Add support for custom roles * Fix doc * Fix wrong comment
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
* Add support for custom roles * Fix doc * Fix wrong comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1183
Resolves #1222
Resolves #1334
@kfcampbell
Behavior
Before the change?
After the change?
Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance