use GetRoleName() instead of permission mapping func#1192
use GetRoleName() instead of permission mapping func#1192kfcampbell merged 2 commits intointegrations:mainfrom joshua-hancox:fix-read-repo-role
Conversation
kfcampbell
left a comment
There was a problem hiding this comment.
Thank you for doing this! Apologies for the delay.
|
This breaks the resource for non-custom roles as the naming is different. |
|
I'm seeing the same as @csainty. Confusingly, around half of the repositories we manage seem to use "push" and the other half "write". It could look like the oldest repositories we have wants to use "push", so I'm guessing it might have something to do with when the repository is created. Not having it mapped to the same name makes it difficult to use |
|
Same here. This is a breaking change for use. If we keep it as is some 300 repos will be changed on every run, if we change push to write, some 450 repos will be changed every run. We should revert or create some option to have aliases or something. If somebody finds a way to "rename" the roles in Github, please share. That might be a solution as well. |
|
For us some of the differences seem to come from roles/permissions assigned to groups (teams), org members (collaborators) and outside collaborators. That seems to be the difference between in the v3 api: Note that (fyi we only use the default roles) Some information here https://github.community/t/is-the-api-insane-with-respect-to-collaborators-or-am-i-confused/253696 |
|
Created a new ticket in #1222 as comments here might get unnoticed. |
Created by running git revert -n 754d73f HEAD.
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Requires go-github version bump: #1205
fixes: #1183