Build master/test executor shutdown timeouts#10220
Closed
Conversation
arnaudsjs
approved these changes
Mar 30, 2026
Hugo-Inmanta
approved these changes
Mar 30, 2026
Contributor
|
Processing this pull request |
inmantaci
pushed a commit
that referenced
this pull request
Mar 30, 2026
# Description Fixed a timeout in a test case that waits for executors to shut down. I introduced the `shortlived_executors` fixture that configures the retention time at 1s. The test previously timed out at `> 10s`, but with this change I think we can safely set it to 2s. The test failure I observed on Jenkins was on `test_pause_agent_deploy`, but I believe it applies just as well to the two other tests that wait for executor shutdown, so I made them use the fixture as well. # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
inmantaci
pushed a commit
that referenced
this pull request
Mar 30, 2026
# Description Fixed a timeout in a test case that waits for executors to shut down. I introduced the `shortlived_executors` fixture that configures the retention time at 1s. The test previously timed out at `> 10s`, but with this change I think we can safely set it to 2s. The test failure I observed on Jenkins was on `test_pause_agent_deploy`, but I believe it applies just as well to the two other tests that wait for executor shutdown, so I made them use the fixture as well. # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
Contributor
|
Merged into branches iso9, master in d18814d |
Contributor
|
Processing #10222. |
inmantaci
pushed a commit
that referenced
this pull request
Mar 30, 2026
Pull request opened by the merge tool on behalf of #10220
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a timeout in a test case that waits for executors to shut down. I introduced the
shortlived_executorsfixture that configures the retention time at 1s. The test previously timed out at> 10s, but with this change I think we can safely set it to 2s.The test failure I observed on Jenkins was on
test_pause_agent_deploy, but I believe it applies just as well to the two other tests that wait for executor shutdown, so I made them use the fixture as well.Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the box