Skip to content

Build master/test executor shutdown timeouts (#10220)#10222

Closed
inmantaci wants to merge 1 commit intoiso8from
merge-tool/10220/iso8
Closed

Build master/test executor shutdown timeouts (#10220)#10222
inmantaci wants to merge 1 commit intoiso8from
merge-tool/10220/iso8

Conversation

@inmantaci
Copy link
Copy Markdown
Contributor

Pull request opened by the merge tool on behalf of #10220

# Description

Fixed a timeout in a test case that waits for executors to shut down. I introduced the `shortlived_executors` fixture that configures the retention time at 1s. The test previously timed out at `> 10s`, but with this change I think we can safely set it to 2s.

The test failure I observed on Jenkins was on `test_pause_agent_deploy`, but I believe it applies just as well to the two other tests that wait for executor shutdown, so I made them use the fixture as well.

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
@inmantaci inmantaci added the merge-tool-ready This ticket is ready to be merged in label Mar 30, 2026
@inmantaci
Copy link
Copy Markdown
Contributor Author

Merged into branches iso8 in c04c322

@inmantaci inmantaci closed this Mar 30, 2026
@inmantaci inmantaci deleted the merge-tool/10220/iso8 branch March 30, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-tool-ready This ticket is ready to be merged in

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants