Skip to content

Several Improvements#43

Closed
Bakual wants to merge 3 commits intoinfograf768:newsaddassocfrontendfrom
Bakual:newsaddassocfrontend
Closed

Several Improvements#43
Bakual wants to merge 3 commits intoinfograf768:newsaddassocfrontendfrom
Bakual:newsaddassocfrontend

Conversation

@Bakual
Copy link
Copy Markdown

@Bakual Bakual commented Sep 15, 2016

I've made the following changes:

  • Rewrote ContentHelperAssociation::displayAssociations() quite a bit. It now only returns an array with the association item (the URL) and the language object instead of generated HTML. Also changed it so it only does one foreach on the language and not multiple times like it did before.
  • Registered the ContentHelperAssociation class in the components entry point so we don't have to load it in every view.
  • Rewrote the JLayout so it generates the HTML itself. It can be easily overriden by templates. It's now also reusable by other extensions.
  • Removed the "Show_Flag" param. If it is deemed necessary it can be added back and a conditional put into the JLayout and the default_items layout from the category view. It should even work on menuitem and article level now if needed.
  • The association data is now collected in the articles model and the article view respectively (same as other data like tags).

@infograf768
Copy link
Copy Markdown
Owner

I will now close this.
Thanks.
Used your code but kept the choice for sef icons or flags. You know why.

@Bakual Bakual deleted the newsaddassocfrontend branch September 16, 2016 07:34
infograf768 pushed a commit that referenced this pull request Jun 10, 2017
* Codestyle

* indent

* order

* oops

* changes requested by @andrepereiradasilva

* cs

* changes requested by @wojsmol

* Update mod_logged.xml (#43)

* Update templateDetails.xml (#45)

i need to fix my ide!!

* Update mod_popular.xml (#44)

* Update templateDetails.xml (#57)

* Update mod_version.xml (#56)

* Update mod_toolbar.xml (#55)

* Update mod_title.xml (#54)

* Update mod_submenu.xml (#53)

* Update mod_status.xml (#52)

* Update mod_stats_admin.xml (#51)

* Update mod_quickicon.xml (#50)

* Update mod_menu.xml (#49)

* Update mod_login.xml (#48)

* Update mod_latest.xml (#47)

* Update mod_feed.xml (#46)
infograf768 pushed a commit that referenced this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants