Fix RabbitMQ regression in #9383#9443
Merged
sspaink merged 19 commits intoinfluxdata:masterfrom Jun 29, 2021
Merged
Conversation
added 8 commits
June 28, 2021 16:17
…ined information.
… errors if optional plugin is not operational.
added 8 commits
June 28, 2021 18:28
akrantz01
suggested changes
Jun 28, 2021
Contributor
akrantz01
left a comment
There was a problem hiding this comment.
Overall LGTM. I just left some comments on some of the type conversion for Memory.Total.
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Member
Author
|
@akrantz01 thanks for review. I changed the code according to your suggestions except for the |
akrantz01
approved these changes
Jun 29, 2021
sspaink
approved these changes
Jun 29, 2021
reimda
pushed a commit
that referenced
this pull request
Jul 7, 2021
bhsu-ms
pushed a commit
to bhsu-ms/telegraf
that referenced
this pull request
Jul 12, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
resolves #9383
This resolves the wrong types for
_avgmetrics. Those errors went unnoticed before checking the return types (#8992) and returned invalid values (all zero) if the server responded with as floating-point formatted number by chance.This PR furthermore tries to handle missing plugins (e.g.
federation) more gracefully providing the server sent error to the user. To avoid those errors altogether, a (backward-compatible) metric-filter is introduced such that the user can disable erroneous metrics.