Skip to content

Linter fixes (unhandled errors) -- Part 1#8992

Merged
sspaink merged 20 commits intoinfluxdata:masterfrom
HRI-EU:linter-fixes
Apr 8, 2021
Merged

Linter fixes (unhandled errors) -- Part 1#8992
sspaink merged 20 commits intoinfluxdata:masterfrom
HRI-EU:linter-fixes

Conversation

@srebhan
Copy link
Copy Markdown
Member

@srebhan srebhan commented Mar 15, 2021

Required for all PRs:

  • Associated README.md updated.
  • Has appropriate unit tests.

This PR fixes 545 golangci-lint issues on unhandled error values in the plugins/input directory. It covers all input plugins starting with hd to z.

Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Mar 15, 2021
@srebhan srebhan added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Mar 15, 2021
Copy link
Copy Markdown
Collaborator

@zak-pawel zak-pawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enormous work! Just two minor comments.

Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sspaink sspaink merged commit 8e7da35 into influxdata:master Apr 8, 2021
@srebhan srebhan deleted the linter-fixes branch April 12, 2021 08:28
jblesener pushed a commit to jblesener/telegraf that referenced this pull request Apr 18, 2021
@srebhan srebhan mentioned this pull request Jun 28, 2021
2 tasks
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix pr to fix corresponding bug linter plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants