Migrate from github.com/ericchiang/k8s to github.com/kubernetes/client-go#8937
Migrate from github.com/ericchiang/k8s to github.com/kubernetes/client-go#8937sspaink merged 9 commits intoinfluxdata:masterfrom
Conversation
ivorybilled
left a comment
There was a problem hiding this comment.
Nice, makes some of the code cleaner too
…t-go (influxdata#8937) * new k8 client * Make all tests pass * Update licenses * add timeout back * Resolve merge conflicts * Fix tests and linter * Fix linter errors * Linting issues * Extra empty line Co-authored-by: Bas <3441183+BattleBas@users.noreply.github.com>
|
@sspaink I am observing some issue related to the changes in this line and related logic. I am getting a string(val.Format) value as either "DecimalSI" or "BinarySI" and hence getting error while parsing these values. Logs from parser: 2021-08-03T03:37:20Z D! [inputs.kube_inventory] failed to parse quantity: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP][-+]?[0-9])$' Once I convert string(val.Format) to val.String(), things seem to work fine. May I know why format is used as input to Similar bug has been raised already. |
|
@varunjain0606 Thank you for reporting this issue, looks like using format was a mistake. I noticed your pr #9581 to fix this, thank you for resolving it so quickly! |
|
@sspaink No problem. Glad to help. Cheers! |
…t-go (influxdata#8937) * new k8 client * Make all tests pass * Update licenses * add timeout back * Resolve merge conflicts * Fix tests and linter * Fix linter errors * Linting issues * Extra empty line Co-authored-by: Bas <3441183+BattleBas@users.noreply.github.com> (cherry picked from commit 79f5803)
…t-go (influxdata#8937) * new k8 client * Make all tests pass * Update licenses * add timeout back * Resolve merge conflicts * Fix tests and linter * Fix linter errors * Linting issues * Extra empty line Co-authored-by: Bas <3441183+BattleBas@users.noreply.github.com>
The Kubernetes client project
ericchiang/k8shas been archived since 2019, looks likekubernetes/client-gois the replacement. Migrated the plugin kube_inventory and Prometheus to use the new client.