Skip to content

Add the Timestream Output Plugin #8239

Merged
ssoroka merged 3 commits intoinfluxdata:masterfrom
aws:telegraf_master_with_Timestream
Oct 15, 2020
Merged

Add the Timestream Output Plugin #8239
ssoroka merged 3 commits intoinfluxdata:masterfrom
aws:telegraf_master_with_Timestream

Conversation

@piotrwest
Copy link
Copy Markdown
Contributor

@piotrwest piotrwest commented Oct 7, 2020

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

This is continuation of #8211 using a different source branch, to apply all necessary changes, without editing aws:telegraf_v1.15.3_with_Timestream branch.

We have created a new Telegraf output plugin that is able to write metrics to Amazon Timestream. Please see the details in README.md file.

@piotrwest piotrwest mentioned this pull request Oct 7, 2020
Closed
3 tasks
@piotrwest
Copy link
Copy Markdown
Contributor Author

piotrwest commented Oct 7, 2020

Thank you @ssoroka for looking at this. I have applied your remarks, continuing #8211 .

@ssoroka
Copy link
Copy Markdown
Contributor

ssoroka commented Oct 8, 2020

Looks good. Looks like the build is failing in 1.14 due to make fmt mismatch.

@sjwang90 sjwang90 added area/aws AWS plugins including cloudwatch, ecs, kinesis new plugin labels Oct 8, 2020
@piotrwest
Copy link
Copy Markdown
Contributor Author

piotrwest commented Oct 8, 2020

Great! Quick question regarding make fmt mismatch - is it something I should fix? If so, can you give me guidance how to do that? If not, when we can expect this pull request to be merged?

@reimda
Copy link
Copy Markdown
Contributor

reimda commented Oct 12, 2020

Hi @piotrwest, the telegraf CI build checks your code to make sure it has been formatted correctly. It does this to keep the code indentation, spacing, etc looking the same independent of who wrote it.

The makefile has a target that will reformat the code for you so it passes the format check. You just need to check out your pr branch, run "make fmt", commit the files that it modified, and push to your pr branch. Once that's done CI will run again and the format check should pass.

@piotrwest
Copy link
Copy Markdown
Contributor Author

piotrwest commented Oct 12, 2020

Thank you @reimda for the explanation. I've fixed formatting issues. The code is ready to be merged in now.

@ssoroka ssoroka merged commit 7c2c2c5 into influxdata:master Oct 15, 2020
@piotrwest piotrwest deleted the telegraf_master_with_Timestream branch October 15, 2020 20:59
@sjwang90 sjwang90 mentioned this pull request Oct 15, 2020
Closed
ssoroka pushed a commit that referenced this pull request Oct 16, 2020
@piotrwest @ssoroka
Add the Timestream Output Plugin (#8239)
0fd7e40 
Co-authored-by: Piotr Westfalewicz <westpiot@amazon.com>
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@piotrwest
Add the Timestream Output Plugin (influxdata#8239)
d5e1966 
Co-authored-by: Piotr Westfalewicz <westpiot@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/aws AWS plugins including cloudwatch, ecs, kinesis new plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@piotrwest @ssoroka @reimda @sjwang90