Add the Timestream Output Plugin#8211
Add the Timestream Output Plugin#8211piotrwest wants to merge 1 commit intoinfluxdata:release-1.15from
Conversation
|
Hey @piotrwest, if you're an employee of Amazon we also need you and any other employees involved in building this plugin to sign the Corporate CLA. Amazon.com Services, Inc has executed a CCLA in the past but we would still need you to be covered on the Schedule A portion. Please let us know if you have any questions! |
|
Amazon Timestream Issue #5539 |
| Execute unit tests with: | ||
|
|
||
| ``` | ||
| go test -v ./plugins/outputs/timestream/timestream_test.go ./plugins/outputs/timestream/timestream_internal_test.go ./plugins/outputs/timestream/timestream.go |
There was a problem hiding this comment.
| go test -v ./plugins/outputs/timestream/timestream_test.go ./plugins/outputs/timestream/timestream_internal_test.go ./plugins/outputs/timestream/timestream.go | |
| go test -v ./plugins/outputs/timestream/... |
|
|
||
| func (t *Timestream) writeToTimestream(writeRecordsInput *timestreamwrite.WriteRecordsInput, resourceNotFoundRetry bool) error { | ||
| if t.Debug { | ||
| log.Printf("I! Timestream: Writing to Timestream: '%v' with ResourceNotFoundRetry: '%t'", writeRecordsInput, resourceNotFoundRetry) |
There was a problem hiding this comment.
instead of adding a Debug parameter and using log.Printf, you can just use the Log telegraf.Logger you already added to the struct, which has a Debug method, and respects the global debug flags. For tests, set the logger to testutil.Logger{}. Then you can also remove the LogLevel and plugin name from the log lines and they will conform to the Telegraf standards.
|
Hey @piotrwest! We were able to get you on Amazon's Corporate CLA. Once @ssoroka's comments are addressed we can look at getting this merged. |
|
That's great, thank you @sjwang90 . I had created a new pull request: #8239 . Closing this one. I will continue with applying feedback from @ssoroka there, which was not possible here, as the source branch name (telegraf_v1.15.3_with_Timestream) was fixed on a specific version. I didn't want to confuse the customers by reusing it for a pull request purposes. |
Required for all PRs:
We have created a new Telegraf output plugin that is able to write metrics to Amazon Timestream. Please see the details in README.md file.
Closes #5539