Update procstat to support cgroup globs & include systemd unit children#7890
Update procstat to support cgroup globs & include systemd unit children#7890DEvil0000 wants to merge 7 commits intoinfluxdata:masterfrom
Conversation
DEvil0000
commented
Jul 24, 2020
- cgroups now support glob
- systemd_unit in combination with systemd_all will now report for all children and not just the main pid of the service
- in case cgroups or systemd_unit+all will return a group of pids they get tagged with their actual cgroup/service matched (cgroup_full)
- Signed CLA.
- Associated README.md updated.
- Has appropriate unit tests.
|
Hi @sjwang90, is this update going to be merged soon? |
|
Sorry for the delay - we'll get this reviewed. |
sspaink
left a comment
There was a problem hiding this comment.
Thank you for working on this pull request! It does look it will improve the procstat plugin, I've added some review comments for you to look at.
| ## user as argument for pgrep (ie, pgrep -u <user>) | ||
| # user = "nginx" | ||
| ## Systemd unit name | ||
| ## Systemd unit name or glob and if all processes of the unit should get collected |
There was a problem hiding this comment.
Shouldn't the "or glob..." line also be above the cgroup setting? And it seems systemd_unit only supports globs when systemd_all is set to true.
| ## Systemd unit name | ||
| ## Systemd unit name or glob and if all processes of the unit should get collected | ||
| # systemd_unit = "nginx.service" | ||
| # systemd_all = true |
There was a problem hiding this comment.
Maybe this should be renamed to something like include_systemd_unit_children, that would be more descriptive. Thoughts?
| # user = "nginx" | ||
| ## Systemd unit name | ||
| # systemd_unit = "nginx.service" | ||
| # systemd_all = true |
There was a problem hiding this comment.
I think this should be false to not change original behavior
|
@sspaink thanks for the review! |
|
@DEvil0000 thank you for letting us know, sorry for taking so long with the review. I'll look into taking over the pull request and work with the team to get it merged. I will be sure mention your contribution and let you know once it is in master/released. |
|
Thank you! Thank you for taking care! |
|
#9488 will continue this pull request. |
* origin/master: (183 commits) fix: CrateDB replace dots in tag keys with underscores (influxdata#9566) feat: Pull metrics from multiple AWS CloudWatch namespaces (influxdata#9386) fix: improve Clickhouse corner cases for empty recordset in aggregation queries, fix dictionaries behavior (influxdata#9401) fix(opcua): clean client on disconnect so that connect works cleanly (influxdata#9583) fix: Refactor ec2 init for config-api (influxdata#9576) fix: sort logs by timestamp before writing to Loki (influxdata#9571) fix: muting tests for udp_listener (influxdata#9578) fix: Do not return on disconnect to avoid breaking reconnect (influxdata#9524) fix: Fixing k8s nodes and pods parsing error (influxdata#9581) feat: OpenTelemetry output plugin (influxdata#9228) feat: Support AWS Web Identity Provider (influxdata#9411) fix: upgraded sensu/go to v2.9.0 (influxdata#9577) fix: Normalize unix socket path (influxdata#9554) docs: fix aws ec2 readme inconsistency (influxdata#9567) feat: Modbus Rtu over tcp enhancement (influxdata#9570) docs: information on new conventional commit format (influxdata#9573) docs: Add logo (influxdata#9574) docs: Adding links to net_irtt and dht_sensor external plugins (influxdata#9569) Upgrade hashicorp/consul/api to 1.9.1 (influxdata#9565) Update vmware/govmomi to v0.26.0 (influxdata#9552) Do not skip good quality nodes after a bad quality node is encountered (influxdata#9550) fix test so it hits a fake service (influxdata#9564) Update changelog Fix procstat plugin README to match sample config (influxdata#9553) Fix metrics reported as written but not actually written (influxdata#9526) Prevent segfault in persistent volume claims (influxdata#9549) Update procstat to support cgroup globs & include systemd unit children (Copy of influxdata#7890) (influxdata#9488) Fix attempt to connect to an empty list of servers. (influxdata#9503) Fix handling bool in sql input plugin (influxdata#9540) Suricata alerts (influxdata#9322) Linter fixes for plugins/inputs/[fg]* (influxdata#9387) For Prometheus Input add ability to query Consul Service catalog (influxdata#5464) Support Landing page on Prometheus landing page (influxdata#8641) [Docs] Clarify tagging behavior (influxdata#9461) Change the timeout from all queries to per query (influxdata#9471) Attach the pod labels to the `kubernetes_pod_volume` & `kubernetes_pod_network` metrics. (influxdata#9438) feat(http_listener_v2): allows multiple paths and add path_tag (influxdata#9529) Bug Fix Snmp empty metric name (influxdata#9519) Worktable workfile stats (influxdata#8587) Update Go to v1.16.6 (influxdata#9542) ...