Skip to content

chore(deps): Bump github.com/eclipse/paho.mqtt.golang from 1.3.5 to 1.4.1#11347

Merged
sspaink merged 2 commits intomasterfrom
dependabot/go_modules/github.com/eclipse/paho.mqtt.golang-1.4.1
Aug 1, 2022
Merged

chore(deps): Bump github.com/eclipse/paho.mqtt.golang from 1.3.5 to 1.4.1#11347
sspaink merged 2 commits intomasterfrom
dependabot/go_modules/github.com/eclipse/paho.mqtt.golang-1.4.1

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Jun 21, 2022 •
edited
Loading

Bumps github.com/eclipse/paho.mqtt.golang from 1.3.5 to 1.4.1.

Release notes

Sourced from github.com/eclipse/paho.mqtt.golang's releases.

v1.4.1

The license update in v1.4.0 included changes which prevented https://pkg.go.dev from displaying the documentation. The only change in this release is to update LICENSE such that it includes the full test of the Eclipse Public License v2.0 (tested this on a fork and it appears to resolve the issue).

v1.4.0

In the year since the release of v1.3.5 the majority of changes have been small incremental improvements/fixes. It is worth noting that the library has moved to the EPL v2.0 license (faq).

A few new features have been added:

  • Managing the connection to the broker can become involved (e.g. setting unusual TCP/TLS options, need for a non-standard TLS library, require a specific web-socket library etc) and the library already has too many options! To address this a new option, SetCustomOpenConectionFn, has been added that enables users to provide a function (func(uri *url.URL, options ClientOptions) (net.Conn, error)) that will be called to establish a connection (replacing the inbuilt code). This should enable edge cases to be addressed without the need for further changes to this library.
  • When connecting/reconnecting it is possible that there will be a lot of packets queued; in the past the library sent all of these packets as rapidly as possible when the connection came up. However this could saturate some network links causing the connection to drop (a vicious circle). The new option SetMaxResumePubInFlight allows a limit to be imposed; the library will send out the requested number of packets and then wait for acknowledgements before sending more (only applicable at QOS1+).

Thanks to everyone who submitted issues and contributed code (list of the main merged pull requests below):

What's Changed

New Contributors

Full Changelog: eclipse-paho/paho.mqtt.golang@v1.3.5...v1.4.0

Commits
  • bcb58ee Update license to meet pkg.go.dev requirements
  • 8717376 Merge pull request #590 from ptsneves/pneves-disconnect-workaround
  • 2e83582 client.go Remove Disconnect()'s wait on c.commsStopped.
  • eaac59b Merge pull request #586 from ptsneves/disconnect-refactor
  • ac29fdf client: localized disconnectSent logic
  • 3ec7db3 client: refactor setConnected(disconnected) out of conditional
  • 7254d2c client: set disconnect as defer
  • 2d3b04d Merge pull request #577 from ChIoT-Tech/master
  • 721bf9f If c.options.Dialer was nil this caused a panic.
  • 44f71c7 Merge pull request #575 from GilGil1/master
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 21, 2022
@telegraf-tiger telegraf-tiger bot added the chore label Jun 21, 2022
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/eclipse/paho.mqtt.golang-1.4.1 branch from 7ccbdf0 to 53a9de2 Compare June 22, 2022 21:04
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/eclipse/paho.mqtt.golang-1.4.1 branch from 53a9de2 to b09d800 Compare July 6, 2022 16:16
srebhan
srebhan previously approved these changes Jul 8, 2022
View reviewed changes
@srebhan srebhan dismissed their stale review July 8, 2022 13:42

License change in minor version.

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/eclipse/paho.mqtt.golang-1.4.1 branch from b09d800 to 4b2560d Compare July 14, 2022 14:01
@srebhan
Copy link
Copy Markdown
Member

srebhan commented Jul 21, 2022

@MyaLongmire please note that the license changed for 1.4.1, that's why I did not approve it yet. We probably what to adapt docs/LICENSE_OF_DEPENDENCIES.md and get #11398 in...

@MyaLongmire
Copy link
Copy Markdown
Contributor

MyaLongmire commented Jul 21, 2022

@srebhan thanks for pointing that out!

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/eclipse/paho.mqtt.golang-1.4.1 branch 2 times, most recently from d12f3bd to 372e02e Compare July 28, 2022 12:30
@sspaink
Copy link
Copy Markdown
Contributor

sspaink commented Jul 29, 2022

@dependabot rebase

@dependabot
chore(deps): Bump github.com/eclipse/paho.mqtt.golang
fe93d70 
Bumps [github.com/eclipse/paho.mqtt.golang](https://github.com/eclipse/paho.mqtt.golang) from 1.3.5 to 1.4.1.
- [Release notes](https://github.com/eclipse/paho.mqtt.golang/releases)
- [Commits](eclipse-paho/paho.mqtt.golang@v1.3.5...v1.4.1)

---
updated-dependencies:
- dependency-name: github.com/eclipse/paho.mqtt.golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/eclipse/paho.mqtt.golang-1.4.1 branch from 372e02e to fe93d70 Compare July 29, 2022 19:00
@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 29, 2022
@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Jul 29, 2022

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

srebhan
srebhan approved these changes Aug 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @sspaink for fixing this up!

@sspaink sspaink merged commit e7e3926 into master Aug 1, 2022
@sspaink sspaink deleted the dependabot/go_modules/github.com/eclipse/paho.mqtt.golang-1.4.1 branch August 1, 2022 19:03
reimda pushed a commit that referenced this pull request Aug 15, 2022
@dependabot @reimda
chore(deps): Bump github.com/eclipse/paho.mqtt.golang from 1.3.5 to 1…
6c636c1 
….4.1 (#11347)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Spaink <sspaink@influxdata.com>
(cherry picked from commit e7e3926)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srebhan srebhan srebhan approved these changes

+1 more reviewer

@MyaLongmire MyaLongmire MyaLongmire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@srebhan @MyaLongmire @sspaink