Add warning to Disconnect function#537
Merged
MattBrittan merged 1 commit intoeclipse-paho:masterfrom Sep 16, 2021
Merged
Conversation
This was referenced Jun 5, 2022
Update module github.com/eclipse/paho.mqtt.golang to v1.5.1 - autoclosed
sapcc/mosquitto-exporter#41
Closed
This was referenced Jun 18, 2022
Closed
Closed
Closed
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per issues #488, #529 and #536 (probably others too) calling
Disconnectmay not leave the client safe for reuse. I'm not in a position to put the time into fixing this currently (and do not see any obvious use-case; the built in functionality should handle reconnects etc) so am adding a warning for the time being.