Skip to content

chore(cli): hide the token's env var value in cli help#26714

Merged
philjb merged 1 commit intomainfrom
pjb/26713/hide-token-values-in-help
Aug 22, 2025
Merged

chore(cli): hide the token's env var value in cli help#26714
philjb merged 1 commit intomainfrom
pjb/26713/hide-token-values-in-help

Conversation

@philjb
Copy link
Copy Markdown
Contributor

@philjb philjb commented Aug 21, 2025

Use clap crate's "hide_env_values" option to suppress displaying the current value of the env var of the db token INFLUXDB3_AUTH_TOKEN when displaying cli help. The default behavior of clap is to display env var values for arguments when displaying the generated help messages. Showing the token disrupts formatting of the help because it is often long and in a way leaks the token's value.

@philjb philjb added the v3 label Aug 21, 2025
Use clap crate's "hide_env_values" option to suppress displaying the
current value of the env var of the db token INFLUXDB3_AUTH_TOKEN when
displaying cli help. The default behavior of clap is to display env var
values for arguments when displaying the generated help messages.
Showing the token disrupts formatting of the help because it is often
long and in a way leaks the token's value.

* closes #26713
@philjb philjb force-pushed the pjb/26713/hide-token-values-in-help branch from fc7ffe6 to d767267 Compare August 21, 2025 20:14
@philjb philjb marked this pull request as ready for review August 21, 2025 21:00
@philjb philjb requested a review from hiltontj August 21, 2025 21:00
@philjb philjb merged commit 31173c2 into main Aug 22, 2025
12 checks passed
@philjb philjb deleted the pjb/26713/hide-token-values-in-help branch August 22, 2025 04:00
mgattozzi pushed a commit that referenced this pull request Sep 8, 2025
* chore(wal_replay): port limit concurrency of replay

* port #26716 to ent
* ticket #26715

* chore(cli): port hide the token's env value in cli help

* port #26714
* ticket #26713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v3][core] Hide token value when displaying help

2 participants