Add Raft endpoints and fix cluster init bugs#1212
Add Raft endpoints and fix cluster init bugs#1212otoolep merged 4 commits intoinfluxdata:masterfrom otoolep:add_raft_endpoints
Conversation
cmd/influxd/create_cluster.go
Outdated
There was a problem hiding this comment.
The config.sample.toml only makes sense in the context of running inside of the influxdb directory, doesn't it? I'm not sure if this is useful for most end users who download the binary.
There was a problem hiding this comment.
Perhaps. This is a straight copy from the existing code. If we do remove it, we need to make the error message more helpful when it is not supplied. Currently it's
config: open : no such file or directory
which isn't great.
|
Also, minor nit, but "Raft" is just spelled with initial case. It's not an acronym. Not sure why it's called Raft actually... |
|
Thanks @benbjohnson -- will stop capitalizing Raft. |
If a Broker is running on the node, we need ensure the handler will service its endpoints.
|
OK, all comments addressed. The error message is OK, as long as a path is in there. I think it pretty clear for now: |
cmd/influxd/create_cluster.go
Outdated
There was a problem hiding this comment.
/etc/influxdb.conf is beginning to feel like a magic string that should be defined elsewhere. Perhaps some path called paths.go, in the main package.
Any thoughts?
There was a problem hiding this comment.
You can make a constant at the top of main.go:
const DefaultConfigPath = `/etc/influxdb.conf`There was a problem hiding this comment.
OK, I'm happy with that. I think it's the most logical place to put some of these string constants.
|
As we've discussed, I'm sure this is far from the final code, but this is a stepping stone to getting a real 3-combined-node cluster going. With this in place I should be able to start a single node that is truly running in 'combined' mode. |
|
👍 |
|
@benbjohnson -- thanks. I'm going to make the constant change, and then merge. |
They were missing for 'create-cluster' and 'join-cluster'.
Add Raft endpoints and fix cluster init bugs
No description provided.