fix(tsi1/partition/test): fix data race in test code#25298
Merged
Conversation
davidby-influx
requested changes
Sep 9, 2024
Contributor
davidby-influx
left a comment
There was a problem hiding this comment.
Check error returns on test cleanup
|
|
||
| p := MustOpenPartition(sfile.SeriesFile) | ||
| defer func() { | ||
| t.Cleanup(func() { |
Contributor
There was a problem hiding this comment.
Can we use this pattern in more of the calls to t.Cleanup?
Author
There was a problem hiding this comment.
👍 Sounds good I'll go ahead and adjust
tsdb/index/tsi1/partition_test.go
Outdated
| t.Cleanup(func() { sfile.Close() }) | ||
|
|
||
| p := MustOpenPartition(sfile.SeriesFile) | ||
| t.Cleanup(func() { p.Close() }) |
Contributor
There was a problem hiding this comment.
I dislike the t.Cleanup does not check error returns. If the file or partition fails to close, that seems like an important failure in the test.
Author
|
@davidby-influx I modified the test cleanups to include error handling. I'll go ahead and modify #25288 to include those changes as well 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24041
Describe your proposed changes here.