Skip to content

fix(tsi1/partition/test): fix data race in test code#25288

Merged
devanbenz merged 8 commits intomaster-1.xfrom
db-backport-24613
Sep 12, 2024
Merged

fix(tsi1/partition/test): fix data race in test code#25288
devanbenz merged 8 commits intomaster-1.xfrom
db-backport-24613

Conversation

@devanbenz
Copy link
Copy Markdown

@devanbenz devanbenz commented Sep 6, 2024

Cherry picks in #24613
Had to resolve a few merge conflicts as well

Describe your proposed changes here.

  • I've read the contributing section of the project README.
  • Signed CLA (if not already signed).

@devanbenz devanbenz force-pushed the db-backport-24613 branch 3 times, most recently from 3f0bef1 to 19ca175 Compare September 6, 2024 22:35
Copy link
Copy Markdown
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

newFileSet := p.fileSet.PrependLogFile(f)

errors2.Capture(&rErr, func() error {
defer errors2.Capture(&rErr, func() error {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

data race between test and product code in partition compaction [Port to master-1.x]

3 participants