feat: add hook for optimizing series reads based on authorizer#25207
Merged
gwossum merged 3 commits intomaster-1.xfrom Aug 2, 2024
Merged
feat: add hook for optimizing series reads based on authorizer#25207gwossum merged 3 commits intomaster-1.xfrom
gwossum merged 3 commits intomaster-1.xfrom
Conversation
davidby-influx
requested changes
Jul 31, 2024
Contributor
davidby-influx
left a comment
There was a problem hiding this comment.
I need to see the rest of the context to understand this.
davidby-influx
previously approved these changes
Aug 2, 2024
Contributor
davidby-influx
left a comment
There was a problem hiding this comment.
LGTM - one non-blocking typo in comment.
devanbenz
pushed a commit
that referenced
this pull request
Sep 4, 2024
devanbenz
pushed a commit
that referenced
this pull request
Sep 4, 2024
(cherry picked from commit 2cf2103)
devanbenz
added a commit
that referenced
this pull request
Sep 4, 2024
devanbenz
added a commit
that referenced
this pull request
Sep 17, 2024
…25345) * feat: add hook for optimizing series reads based on authorizer (#25207) * fix(tsi1/partition/test): fix data races in test code (#57) (#25338) * fix(tsi1/partition/test): fix data races in test code (#57) * fix(tsi1/partition/test): fix data races in test code This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged. (cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f) * feat: modify error handling to be more idiomatic closes #24042 * fix: errors.Join() filters nil errors --------- Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com> (cherry picked from commit 5c9e45f) --------- Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>
devanbenz
added a commit
that referenced
this pull request
Oct 8, 2024
… (#25438) * feat: add hook for optimizing series reads based on authorizer (#25207) * fix(tsi1/partition/test): fix data races in test code (#57) (#25338) * fix(tsi1/partition/test): fix data races in test code (#57) * fix(tsi1/partition/test): fix data races in test code This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged. (cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f) * feat: modify error handling to be more idiomatic closes #24042 * fix: errors.Join() filters nil errors --------- Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com> (cherry picked from commit 5c9e45f) * fix(ci): Update test_pkgs_64bit image to non-eol ubuntu image (#25354) * fix(ci): Update test_pkgs_64bit image to non-eol ubuntu image * fix: trying edge img * fix(ci): update ubuntu image in ci Update test_pkgs_64bit image to non-eol ubuntu image Please see: discuss.circleci.com/t/linux-image-deprecations-and-eol-for-2024/50177 closes #25355 (cherry picked from commit fdf0df7) --------- Co-authored-by: Geoffrey Wossum <gwossum@influxdata.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.