Skip to content

fix: correct various typos#19987

Merged
danxmoran merged 4 commits intomasterfrom
kumakichi/master
Nov 11, 2020
Merged

fix: correct various typos#19987
danxmoran merged 4 commits intomasterfrom
kumakichi/master

Conversation

@danxmoran
Copy link
Copy Markdown
Contributor

@danxmoran danxmoran commented Nov 11, 2020

Rebased version of #19751 (wasn't able to push changes directly to that PR)

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Feature flagged (if modified API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@danxmoran danxmoran requested a review from a team as a code owner November 11, 2020 14:34
@danxmoran danxmoran mentioned this pull request Nov 11, 2020
8 tasks
@psteinbachs psteinbachs self-requested a review November 11, 2020 17:15
Copy link
Copy Markdown
Contributor

@psteinbachs psteinbachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to fix the rebasing issues and addresses the UI dashboard compat. Good to go.

@danxmoran danxmoran merged commit 15b9531 into master Nov 11, 2020
@danxmoran danxmoran deleted the kumakichi/master branch November 11, 2020 18:54
danxmoran added a commit that referenced this pull request Nov 11, 2020

Co-authored-by: kumakichi <xyesan@gmail.com>
danxmoran added a commit that referenced this pull request Nov 11, 2020
Co-authored-by: kumakichi <xyesan@gmail.com>
danxmoran added a commit that referenced this pull request Nov 11, 2020
Co-authored-by: kumakichi <xyesan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants