Closed
Conversation
russorat
reviewed
Nov 5, 2020
|
|
||
| // DashboardsBucket is the bolt bucket dashboards are stored in | ||
| var DashboardsBucket = []byte("Dashoard") | ||
| var DashboardsBucket = []byte("Dashboard") |
Contributor
There was a problem hiding this comment.
not sure if this is dead code or not, but worried it might have larger impacts.
Contributor
There was a problem hiding this comment.
@glinton I feel like you might be able to answer if this has larger impacts
Contributor
There was a problem hiding this comment.
last i knew it was still being used and changing it would cause old dashboards to go missing. if it's worth it to update this spelling, a migration would need to be written
Contributor
There was a problem hiding this comment.
The only place i found this to be used was in cmd/chronograf-migrator, I think this particular change should be reverted since chronograf still stores dashboards in that misspelled bucket.
If cmd/chronograf-migrator is not the preferred method to migrate from v1, then all this code could be removed.
russorat
reviewed
Nov 5, 2020
|
|
||
| When(/^drag horizontally to "(.*)" of graph cell named "(.*)"$/, async (fraction, name) => { | ||
| await dbdSteps.dragToHorizonatlFractionOfGraphCell(fraction, name); | ||
| await dbdSteps.dragToHorizontalFractionOfGraphCell(fraction, name); |
russorat
reviewed
Nov 5, 2020
|
|
||
| Then(/^there are "(.*)" label pills in the select label popover$/, async count => { | ||
| await dbdsSteps.verifyDasboardAddLabelsPillCount(count); | ||
| await dbdsSteps.verifyDashboardAddLabelsPillCount(count); |
russorat
reviewed
Nov 5, 2020
|
|
||
| When(/^click the add label button for the dashboard card "(.*)"$/, async name => { | ||
| await dbdsSteps.clickDasboardCardAddLabel(name); | ||
| await dbdsSteps.clickDashboardCardAddLabel(name); |
russorat
reviewed
Nov 5, 2020
|
|
||
| When(/^drag horizontally to "(.*)" of the graph$/, async (fraction) => { | ||
| await deSteps.dragToHorizonatalFractionOfGraph(fraction); | ||
| await deSteps.dragToHorizontalFractionOfGraph(fraction); |
russorat
reviewed
Nov 5, 2020
| } | ||
|
|
||
| async verifyDasboardAddLabelsPillCount(count){ | ||
| async verifyDashboardAddLabelsPillCount(count){ |
russorat
reviewed
Nov 5, 2020
| } | ||
|
|
||
| async clickDasboardCardAddLabel(name){ | ||
| async clickDashboardCardAddLabel(name){ |
russorat
reviewed
Nov 5, 2020
| } | ||
|
|
||
| async dragToHorizonatalFractionOfGraph(fraction){ | ||
| async dragToHorizontalFractionOfGraph(fraction){ |
russorat
reviewed
Nov 5, 2020
| }; | ||
|
|
||
| const writePerfomanceReport = async (filename = performanceRecFile) => { | ||
| const writePerformanceReport = async (filename = performanceRecFile) => { |
russorat
reviewed
Nov 5, 2020
| // TestEndpointService_cumulativeSecrets tests that secrets are cumulatively added/updated and removed upon delete | ||
| // see https://github.com/influxdata/influxdb/pull/19082 for details | ||
| func TestEndpointService_cummulativeSecrets(t *testing.T) { | ||
| func TestEndpointService_cumulativeSecrets(t *testing.T) { |
russorat
reviewed
Nov 5, 2020
| UpdateDashboardCellViewF func(ctx context.Context, dashboardID platform.ID, cellID platform.ID, upd platform.ViewUpdate) (*platform.View, error) | ||
| UpdateDashboardCellViewCalls SafeCount | ||
| UpdateDashboardCellF func(ctx context.Context, dashbaordID platform.ID, cellID platform.ID, upd platform.CellUpdate) (*platform.Cell, error) | ||
| UpdateDashboardCellF func(ctx context.Context, dashboardID platform.ID, cellID platform.ID, upd platform.CellUpdate) (*platform.Cell, error) |
russorat
reviewed
Nov 5, 2020
| } | ||
|
|
||
| subcriber := &NatsSubscriber{ | ||
| subscriber := &NatsSubscriber{ |
russorat
reviewed
Nov 5, 2020
| }, | ||
| { | ||
| name: "bad thredshold", | ||
| name: "bad threshold", |
russorat
reviewed
Nov 5, 2020
| // SessionAuthorizionKind defines the type of authorizer | ||
| const SessionAuthorizionKind = "session" | ||
| // SessionAuthorizationKind defines the type of authorizer | ||
| const SessionAuthorizationKind = "session" |
russorat
reviewed
Nov 5, 2020
| // Utils | ||
| import {checkThresholdsValid} from './checkValidate' | ||
| import {isDurationParseable} from 'src/shared/utils/duration' | ||
| import {isDurationParsable} from 'src/shared/utils/duration' |
russorat
reviewed
Nov 5, 2020
|
|
||
| import {SELECTABLE_TIME_RANGES} from 'src/shared/constants/timeRanges' | ||
| import {isDurationWithNowParseable} from 'src/shared/utils/duration' | ||
| import {isDurationWithNowParsable} from 'src/shared/utils/duration' |
russorat
reviewed
Nov 5, 2020
|
|
||
| // Constants | ||
| import {resouceOwner} from 'src/members/dummyData' | ||
| import {resourceOwner} from 'src/members/dummyData' |
russorat
reviewed
Nov 5, 2020
| import {ResourceOwner, User} from '@influxdata/influx' | ||
|
|
||
| export const resouceOwner: ResourceOwner[] = [ | ||
| export const resourceOwner: ResourceOwner[] = [ |
russorat
reviewed
Nov 5, 2020
| ComponentStatus, | ||
| } from '@influxdata/clockface' | ||
| import {isDurationParseable} from 'src/shared/utils/duration' | ||
| import {isDurationParsable} from 'src/shared/utils/duration' |
Contributor
|
@kumakichi can you rebase this PR to resolve the conflicts? |
russorat
reviewed
Nov 5, 2020
| } | ||
|
|
||
| const isRemoveable = | ||
| const isRemovable = |
russorat
reviewed
Nov 5, 2020
| test('broadcasts edited thresholds only when changes are valid', async () => { | ||
| const handleSetThresholdsSpy = jest.fn() | ||
| const testShresholds: Color[] = [ | ||
| const testThresholds: Color[] = [ |
russorat
reviewed
Nov 5, 2020
| millisecondsToDuration, | ||
| isDurationWithNowParseable, | ||
| isDurationParseable, | ||
| isDurationWithNowParsable, |
russorat
reviewed
Nov 5, 2020
| input.replace(/\s/g, '').replace(/now\(\)-/, '') | ||
|
|
||
| export const isDurationWithNowParseable = (lower: string): boolean => { | ||
| export const isDurationWithNowParsable = (lower: string): boolean => { |
Contributor
|
Thanks! reviewed and commented on any areas where the typos were code and not comments or strings. Finding eng team members to take a look as well. |
3 tasks
Contributor
|
@russorat I'll get this rebased |
Contributor
|
Looks like GitHub is going to force me to open a fresh PR to pushed the rebased changes. Holding off for now. |
Contributor
|
Closing in favor of the rebased version #19987 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix some typos