Skip to content

add castOrFail function.#101

Merged
ikesyo merged 2 commits intoikesyo:remove-DecodedTypefrom
tarunon:castOrFail_in_class
Mar 7, 2016
Merged

add castOrFail function.#101
ikesyo merged 2 commits intoikesyo:remove-DecodedTypefrom
tarunon:castOrFail_in_class

Conversation

@tarunon
Copy link
Copy Markdown
Contributor

@tarunon tarunon commented Mar 6, 2016

Workaround for #100

I think the new castOrFail should be include to library.
And I'm concerned NSURL subclass is always fail. (but I think NSURL must be final class.)

@ikesyo ikesyo force-pushed the remove-DecodedType branch from e1059c5 to c72a048 Compare March 7, 2016 10:58
@ikesyo
Copy link
Copy Markdown
Owner

ikesyo commented Mar 7, 2016

@tarunon Could you rebase this to resolve the conflict and to run the tests with #102?

@tarunon tarunon force-pushed the castOrFail_in_class branch from 1cf6973 to 966fd00 Compare March 7, 2016 12:38
@ikesyo
Copy link
Copy Markdown
Owner

ikesyo commented Mar 7, 2016

Thank you @tarunon, this seems a reasonable workaround at the moment. 👌

Merging this 🚢

@ikesyo ikesyo added this to the 2.0.0 milestone Mar 7, 2016
ikesyo added a commit that referenced this pull request Mar 7, 2016
@ikesyo ikesyo merged commit b4b15be into ikesyo:remove-DecodedType Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants