Remove DecodedType typealias (associatedtype) from Decodable protocol by ikesyo · Pull Request #100 · ikesyo/Himotoki

ikesyo · 2016-03-06T13:06:58Z

Addresses #97.

ikesyo · 2016-03-06T14:00:43Z

The build failed on Linux with the following error:

$ swift test
Compiling Swift Module 'Himotokitest' (6 sources)
/home/travis/build/ikesyo/Himotoki/Tests/Himotoki/DecodeErrorTest.swift:25:21: error: constructing an object of class type 'Self' with a metatype value must use a 'required' initializer
        return self.init(string: value)!
               ~~~~ ^
Foundation.NSURL:15:24: note: selected non-required initializer 'init(string:)'
    public convenience init?(string URLString: String)
                       ^
<unknown>:0: error: build had 1 command failures
error: exit(1): swift-build-tool -f /home/travis/build/ikesyo/Himotoki/.build/debug.yaml test

@tarunon Do you have any solution or workaround for this?

tarunon · 2016-03-06T23:34:43Z

Yes, self.init(string: value)! is NSURL, not a Self.
I think we should cast NSURL to Self, but we cannot use Self in implement.
I have one idea, I'll make new pr. :3

ikesyo · 2016-03-07T10:31:13Z

Yes, self.init(string: value)! is NSURL, not a Self.
I think we should cast NSURL to Self, but we cannot use Self in implement.

I'm not sure why this succeeds on OS X with SwiftPM, but fails on Linux. 🤔

tarunon · 2016-03-07T10:47:19Z

I don't know why... But I think Linux is correct.
Because if make NSURL subclass, cannot use self.init(string: String) without override.
It may be swift compiler bug.

tarunon · 2016-03-07T10:54:28Z

Auk,

Yes, self.init(string: value)! is NSURL, not a Self.

I misunderstood this problem, sorry.
It is not necessary that Self has init(string: String) implement.

add castOrFail function.

tarunon · 2016-03-08T00:58:50Z

Sources/StandardLib.swift


-    guard let result = rawValue as? T else {
-        throw typeMismatch("\(T.self)", actual: rawValue, keyPath: nil)
+internal func castOrFail<T>(any: Any) throws -> T {


I think this arguments type must be Any?.
And we need a test of URLHolder decode success case.

I think this arguments type must be Any?.

Any can take Optional<Any>, so it would be fine, I think.

Work arounds a test failure coming from the incompatibility of Optional's string representation between OS X and Linux.

ikesyo · 2016-03-09T14:06:30Z

Okay, this should be good to go now.

@tarunon Do you have further thoughts on this?

tarunon · 2016-03-10T04:37:03Z

Sources/StandardLib.swift


-    guard let result = rawValue as? T else {
-        throw typeMismatch("\(T.self)", actual: rawValue, keyPath: nil)
+internal func castOrFail<T>(any: Any?) throws -> T {


func castOrFail<T>(any: Any?) throws -> T is convenient function in Decodable, so I would like to it to public function, I think.
Or, adding Decodable extension is good for this.

I'm not sure what the real world use case is. The users can implement Decodable.decode(e: Extractor) by using required initializer or also can use Transformer API for decoding non-final classes. Honestly I'm not willing to make it public.

I understand that now.
OK, I have no idea about this pr. Thanks @ikesyo san. 😸

@tarunon I really appreciate your efforts on this! 👍 Many thanks 🙏

ikesyo · 2016-03-11T04:37:55Z

Merging this 🚢

Remove DecodedType typealias (associatedtype) from Decodable protocol

ikesyo added this to the 2.0.0 milestone Mar 6, 2016

tarunon mentioned this pull request Mar 7, 2016

add castOrFail function. #101

Merged

Remove DecodedType typealias (associatedtype) from Decodable protocol

c72a048

ikesyo force-pushed the remove-DecodedType branch from e1059c5 to c72a048 Compare March 7, 2016 10:58

tarunon and others added 5 commits March 7, 2016 21:37

add castOrFail function.

9def1ee

use NSURL.init instead of self.init

966fd00

Merge pull request #101 from tarunon/castOrFail_in_class

b4b15be

add castOrFail function.

Refactor castOrFail

5836503

[CI][Travis] Test with Debug configuration for testable import

3d5634d

ikesyo force-pushed the remove-DecodedType branch from 43fffb6 to 3d5634d Compare March 7, 2016 17:59

tarunon reviewed Mar 8, 2016
View reviewed changes

ikesyo added 3 commits March 9, 2016 13:56

castOrFail<T> should work for T?

e300a1f

Add a test case

1ed874e

Fix a test

dd8341f

Work arounds a test failure coming from the incompatibility of Optional's string representation between OS X and Linux.

ikesyo force-pushed the remove-DecodedType branch from 4bfccbc to dd8341f Compare March 9, 2016 10:49

ikesyo changed the title ~~[WIP] Remove DecodedType typealias (associatedtype) from Decodable protocol~~ Remove DecodedType typealias (associatedtype) from Decodable protocol Mar 9, 2016

ikesyo added the enhancement label Mar 9, 2016

tarunon reviewed Mar 10, 2016
View reviewed changes

ikesyo added a commit that referenced this pull request Mar 11, 2016

Merge pull request #100 from ikesyo/remove-DecodedType

25b6a3d

Remove DecodedType typealias (associatedtype) from Decodable protocol

ikesyo merged commit 25b6a3d into 2.0-development Mar 11, 2016

ikesyo deleted the remove-DecodedType branch March 11, 2016 04:38

ikesyo mentioned this pull request Mar 14, 2016

DecodedType is removable at Swift 2.1 #97

Closed

ikesyo mentioned this pull request Apr 12, 2016

Release 2.0.0 #116

Merged

Conversation

ikesyo commented Mar 6, 2016

Uh oh!

ikesyo commented Mar 6, 2016

Uh oh!

tarunon commented Mar 6, 2016

Uh oh!

ikesyo commented Mar 7, 2016

Uh oh!

tarunon commented Mar 7, 2016

Uh oh!

tarunon commented Mar 7, 2016

Uh oh!

tarunon Mar 8, 2016

Choose a reason for hiding this comment

Uh oh!

ikesyo Mar 8, 2016

Choose a reason for hiding this comment

Uh oh!

ikesyo commented Mar 9, 2016

Uh oh!

tarunon Mar 10, 2016

Choose a reason for hiding this comment

Uh oh!

ikesyo Mar 10, 2016

Choose a reason for hiding this comment

Uh oh!

tarunon Mar 11, 2016

Choose a reason for hiding this comment

Uh oh!

ikesyo Mar 11, 2016

Choose a reason for hiding this comment

Uh oh!

ikesyo commented Mar 11, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants