Add customizable keybindings for the diff view ([keys.diff_view])#527
Merged
idursun merged 3 commits intoidursun:mainfrom Feb 14, 2026
Merged
Conversation
Owner
|
Hey, thanks! This makes sense. I can back port this to #515 as it is not handled there too. I would like to keep the current behaviour (i.e. |
Contributor
Author
Sure, can you check my last commit if that is the expected way to handle this? |
Owner
|
Hey, thanks! Overall looks good but there are test failures need fixing. |
Contributor
Author
|
Oops, forgot about them. Fixed now. |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Feb 18, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [idursun/jjui](https://github.com/idursun/jjui) | patch | `v0.9.11` → `v0.9.12` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>idursun/jjui (idursun/jjui)</summary> ### [`v0.9.12`](https://github.com/idursun/jjui/releases/tag/v0.9.12) [Compare Source](idursun/jjui@v0.9.11...v0.9.12) ### Release 0.9.12 (Final 0.9.x Series) > \[!NOTE] > This is a quick release before marking the end of 0.9.x series due to breaking changes introduced by the work in [#​533](idursun/jjui#533) #### Fixes & Improvements - Modal rendering now fills the entire git, bookmarks, and custom command dialogs before drawing rows, eliminating gaps introduced by the new renderer [#​535](idursun/jjui#535) - Fixed a regression where `ui.colors.selected = { bg = "black" }` no longer highlighted the selected revision by restoring the correct lipgloss → ANSI color conversion [#​534](idursun/jjui#534) - `jj git fetch --tracked` uses the `t` shortcut so `f` remains dedicated to the default fetch, matching the push command’s tracked shortcut [#​532](idursun/jjui#532) - Added a `[keys.diff_view]` config section so diff scrolling, paging, and closing bindings are customizable [#​527](idursun/jjui#527) - Completion now auto-inserts `()` when selecting a parameterless function, improving Lua/script authoring speed [#​530](idursun/jjui#530) - Lua’s `flash()` accepts `error` and `sticky` fields, so scripts can show error toasts and control persistence without additional helpers [#​529](idursun/jjui#529) #### What's Changed - Auto-append () for parameterless functions in completion by [@​Dima-369](https://github.com/Dima-369) in [#​530](idursun/jjui#530) - Add customizable keybindings for the diff view (\[keys.diff\_view]) by [@​Dima-369](https://github.com/Dima-369) in [#​527](idursun/jjui#527) - fix(ui/git): update key for `jj git fetch --tracked` by [@​PrayagS](https://github.com/PrayagS) in [#​532](idursun/jjui#532) #### New Contributors - [@​Dima-369](https://github.com/Dima-369) made their first contribution in [#​530](idursun/jjui#530) **Full Changelog**: <idursun/jjui@v0.9.11...0.9.12> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xOS4yIiwidXBkYXRlZEluVmVyIjoiNDMuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for not opening an issue first to discuss this as per the contributing guidelines — the change felt small enough to submit directly.
The
[keys.diff_view]config section is missing, although other modes like[keys.preview]and[keys.details]have one. I assume this was just an oversight. This PR adds it, making the diff view's scrolling, paging, and close keybindings customizable — the diff is relatively small since it follows the existing pattern.One behavioral change: the separate
Cancel(esc) andQuit(q) handlers are unified into a singleclosekey (defaults to["esc", "q"]), which now always closes the diff view rather thanqquitting the entire app. Happy to revert this part if you'd prefer keeping the quit behavior.