fix: Allow customizing "am" / "pm" strings with locale meridiem function by iamkun · Pull Request #580 · iamkun/dayjs

iamkun · 2019-04-25T12:27:53Z

fix #578

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

#578: Allow customizing "am" / "pm" strings with locale

IssueHunt has been backed by the following sponsors. Become a sponsor

fix #578

codecov-io · 2019-04-25T12:29:20Z

Codecov Report

Merging #580 into dev will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #580   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files       154    154           
  Lines       966    970    +4     
  Branches    131    135    +4     
===================================
+ Hits        966    970    +4

Impacted Files	Coverage Δ
src/locale/ja.js	`100% <100%> (ø)`	⬆️
src/index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aa7143...cd4e31f. Read the comment docs.

ridhoassuryadi · 2019-04-25T12:45:29Z

@@ -19,6 +19,7 @@ const locale = {
    lll: 'YYYY年M月D日 HH:mm',
    llll: 'YYYY年M月D日(ddd) HH:mm'
  },


is it evey locale have this method ?

if locale need other than am/pm might need this. moment.js'locale file is a good reference

lgtm, if we have updated documentation too 👍

ridhoassuryadi · 2019-04-25T12:50:15Z

      hh: get$H(2),
-      a: this.$H < 12 ? 'am' : 'pm',
-      A: this.$H < 12 ? 'AM' : 'PM',
+      a: meridiemFunc(this.$H, this.$m, true),


what if you change the name a into am thats readable object or key, wdyt ?

I think no. This lib is designed to keep the same with moment.js

## [1.8.13](v1.8.12...v1.8.13) (2019-04-26) ### Bug Fixes * Add missing relativeTime and formats for some locales ([#560](#560)) ([96b917e](96b917e)) * Add weekday (locale aware day of the week) plugin ([#569](#569)) ([9007cc5](9007cc5)), closes [#559](#559) * Allow customizing "am" / "pm" strings with locale meridiem function ([#580](#580)) ([576e93e](576e93e)), closes [#578](#578) * Fix `.add` day/week decimal rouding bug ([800f6c9](800f6c9)) * Fix `.diff` type definition error ([#565](#565)) ([c4921ae](c4921ae)), closes [#561](#561) * Fix CustomParseFormat plugin bug ([#568](#568)) ([1f5a9db](1f5a9db)), closes [#555](#555) * Fix relativeTime plugin Math.round bug ([40bea40](40bea40)) * skip square brackets in buddhistEra, advancedFormat plugins ([#556](#556)) ([9279718](9279718)), closes [#554](#554) * Update Indonesian locale([#574](#574)) ([0aa7143](0aa7143)) * Update locale month to support both array and function ([#581](#581)) ([b6599d3](b6599d3)) * Update LocalizedFormat plugin lowercase formats logic ([#557](#557)) ([d409304](d409304))

iamkun · 2019-04-26T15:19:04Z

🎉 This PR is included in version 1.8.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

gka · 2019-04-30T07:31:06Z

yay, thanks!

## [1.8.13](iamkun/dayjs@v1.8.12...v1.8.13) (2019-04-26) ### Bug Fixes * Add missing relativeTime and formats for some locales ([#560](iamkun/dayjs#560)) ([96b917e](iamkun/dayjs@96b917e)) * Add weekday (locale aware day of the week) plugin ([#569](iamkun/dayjs#569)) ([9007cc5](iamkun/dayjs@9007cc5)), closes [#559](iamkun/dayjs#559) * Allow customizing "am" / "pm" strings with locale meridiem function ([#580](iamkun/dayjs#580)) ([576e93e](iamkun/dayjs@576e93e)), closes [#578](iamkun/dayjs#578) * Fix `.add` day/week decimal rouding bug ([800f6c9](iamkun/dayjs@800f6c9)) * Fix `.diff` type definition error ([#565](iamkun/dayjs#565)) ([c4921ae](iamkun/dayjs@c4921ae)), closes [#561](iamkun/dayjs#561) * Fix CustomParseFormat plugin bug ([#568](iamkun/dayjs#568)) ([1f5a9db](iamkun/dayjs@1f5a9db)), closes [#555](iamkun/dayjs#555) * Fix relativeTime plugin Math.round bug ([40bea40](iamkun/dayjs@40bea40)) * skip square brackets in buddhistEra, advancedFormat plugins ([#556](iamkun/dayjs#556)) ([9279718](iamkun/dayjs@9279718)), closes [#554](iamkun/dayjs#554) * Update Indonesian locale([#574](iamkun/dayjs#574)) ([0aa7143](iamkun/dayjs@0aa7143)) * Update locale month to support both array and function ([#581](iamkun/dayjs#581)) ([b6599d3](iamkun/dayjs@b6599d3)) * Update LocalizedFormat plugin lowercase formats logic ([#557](iamkun/dayjs#557)) ([d409304](iamkun/dayjs@d409304))

## [1.8.13](iamkun/dayjs@v1.8.12...v1.8.13) (2019-04-26) ### Bug Fixes * Add missing relativeTime and formats for some locales ([#560](iamkun/dayjs#560)) ([96b917e](iamkun/dayjs@96b917e)) * Add weekday (locale aware day of the week) plugin ([#569](iamkun/dayjs#569)) ([9007cc5](iamkun/dayjs@9007cc5)), closes [#559](iamkun/dayjs#559) * Allow customizing "am" / "pm" strings with locale meridiem function ([#580](iamkun/dayjs#580)) ([576e93e](iamkun/dayjs@576e93e)), closes [#578](iamkun/dayjs#578) * Fix `.add` day/week decimal rouding bug ([800f6c9](iamkun/dayjs@800f6c9)) * Fix `.diff` type definition error ([#565](iamkun/dayjs#565)) ([c4921ae](iamkun/dayjs@c4921ae)), closes [#561](iamkun/dayjs#561) * Fix CustomParseFormat plugin bug ([#568](iamkun/dayjs#568)) ([1f5a9db](iamkun/dayjs@1f5a9db)), closes [#555](iamkun/dayjs#555) * Fix relativeTime plugin Math.round bug ([40bea40](iamkun/dayjs@40bea40)) * skip square brackets in buddhistEra, advancedFormat plugins ([#556](iamkun/dayjs#556)) ([9279718](iamkun/dayjs@9279718)), closes [#554](iamkun/dayjs#554) * Update Indonesian locale([#574](iamkun/dayjs#574)) ([0aa7143](iamkun/dayjs@0aa7143)) * Update locale month to support both array and function ([#581](iamkun/dayjs#581)) ([b6599d3](iamkun/dayjs@b6599d3)) * Update LocalizedFormat plugin lowercase formats logic ([#557](iamkun/dayjs#557)) ([d409304](iamkun/dayjs@d409304))

fix: Allow customizing "am" / "pm" strings with locale meridiem function

734c01a

fix #578

ridhoassuryadi suggested changes Apr 25, 2019

View reviewed changes

iamkun added 2 commits April 26, 2019 11:22

test: Add meridiem test

e964f35

docs: Update meridiem docs

cd4e31f

iamkun merged commit 576e93e into dev Apr 26, 2019

iamkun deleted the fix/am_pm branch April 26, 2019 06:46

iamkun added the released label Apr 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Allow customizing "am" / "pm" strings with locale meridiem function#580

fix: Allow customizing "am" / "pm" strings with locale meridiem function#580
iamkun merged 3 commits into
devfrom
fix/am_pm

iamkun commented Apr 25, 2019 •

edited by issuehunt-oss Bot

Loading

Uh oh!

codecov-io commented Apr 25, 2019 •

edited

Loading

Uh oh!

ridhoassuryadi Apr 25, 2019

Uh oh!

ghost Apr 25, 2019

Uh oh!

ridhoassuryadi Apr 25, 2019

Uh oh!

ridhoassuryadi Apr 25, 2019

Uh oh!

ghost Apr 25, 2019

Uh oh!

ridhoassuryadi Apr 25, 2019

Uh oh!

iamkun commented Apr 26, 2019

Uh oh!

gka commented Apr 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

iamkun commented Apr 25, 2019 • edited by issuehunt-oss Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Referenced issues

Uh oh!

codecov-io commented Apr 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ridhoassuryadi Apr 25, 2019

Choose a reason for hiding this comment

Uh oh!

ghost Apr 25, 2019

Choose a reason for hiding this comment

Uh oh!

ridhoassuryadi Apr 25, 2019

Choose a reason for hiding this comment

Uh oh!

ridhoassuryadi Apr 25, 2019

Choose a reason for hiding this comment

Uh oh!

ghost Apr 25, 2019

Choose a reason for hiding this comment

Uh oh!

ridhoassuryadi Apr 25, 2019

Choose a reason for hiding this comment

Uh oh!

iamkun commented Apr 26, 2019

Uh oh!

gka commented Apr 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iamkun commented Apr 25, 2019 •

edited by issuehunt-oss Bot

Loading

codecov-io commented Apr 25, 2019 •

edited

Loading