fix: Fix .add day/week decimal rouding bug

iamkun · iamkun · commit 800f6c934fdc · 2019-04-08T18:13:16.000+08:00
diff --git a/src/index.js b/src/index.js
@@ -243,7 +243,7 @@ class Dayjs {
     const unit = Utils.p(units)
     const instanceFactorySet = (n) => {
       const date = new Date(this.$d)
-      date.setDate(date.getDate() + (n * number))
+      date.setDate(date.getDate() + Math.round(n * number))
       return Utils.w(date, this)
     }
     if (unit === C.M) {
diff --git a/test/manipulate.test.js b/test/manipulate.test.js
@@ -64,6 +64,13 @@ it('Add Time days', () => {
   expect(dayjs().add('2', 'years').valueOf()).toBe(moment().add('2', 'years').valueOf())
 })
 
+it('Add Time with decimal', () => {
+  expect(dayjs().add(0.4, 'day').valueOf()).toBe(moment().add(0.4, 'day').valueOf())
+  expect(dayjs().add(0.5, 'day').valueOf()).toBe(moment().add(0.5, 'day').valueOf())
+  expect(dayjs().add(0.4, 'week').valueOf()).toBe(moment().add(0.4, 'week').valueOf())
+  expect(dayjs().add(0.5, 'week').valueOf()).toBe(moment().add(0.5, 'week').valueOf())
+})
+
 it('Subtract Time days', () => {
   expect(dayjs().subtract(1, 'days').valueOf()).toBe(moment().subtract(1, 'days').valueOf())
 })

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ class Dayjs {`
`243`	`243`	`const unit = Utils.p(units)`
`244`	`244`	`const instanceFactorySet = (n) => {`
`245`	`245`	`const date = new Date(this.$d)`
`246`		`- date.setDate(date.getDate() + (n * number))`
	`246`	`+ date.setDate(date.getDate() + Math.round(n * number))`
`247`	`247`	`return Utils.w(date, this)`
`248`	`248`	`}`
`249`	`249`	`if (unit === C.M) {`