Skip to content

Auto hdr#9785

Merged
vaxerski merged 3 commits into
hyprwm:mainfrom
UjinT34:auto-hdr
Jun 23, 2025
Merged

Auto hdr#9785
vaxerski merged 3 commits into
hyprwm:mainfrom
UjinT34:auto-hdr

Conversation

@UjinT34

@UjinT34 UjinT34 commented Mar 29, 2025

Copy link
Copy Markdown
Contributor

Describe your PR, what does it fix/add?

Adds render:cm_auto_hdr for fullscreen hdr automation. Should be used with cm_fs_passthrough = 0, won't do anything with other values.
0 - off
1 - sets cm, hdr
2 - sets cm, hdredid

Can be used to fix the same issue as in #9776 in a more reliable way (both PRs are needed to cover all possible configurations)

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Needs more testing with different cm, cm_fs_passthrough and cm_auto_hdr values. Might not work as expected with some combo. I've tested most sensible ones.

Is it ready for merging, or does it need work?

Ready

@LionHeartP

Copy link
Copy Markdown
Contributor

I tested this PR just now with these settings.
monitor=DP-1,2560x1440@144,auto,1, vrr, 0, bitdepth, 10
render:cm_auto_hdr=1 and 2
render:cm_fs_passthrough = 0

While it solved the issue that #9776 also solves, it made the colors look weird in gamescope. I could immediately tell by looking at Mangohud that red looked kinda orange-ish.

I tested the other game I'm currently playing on Steam (RE4R) with wine-wayland, and the colors looked exactly like before, inluding Mangohud.

@UjinT34

UjinT34 commented Mar 29, 2025

Copy link
Copy Markdown
Contributor Author

It's expected to look different.
With passthrough mangohud image description is ignored and it becomes oversaturated. Without passthrough it would be correct... but frog-cm assumes that everything is hdr and gamescope has some builtin cm. This results in double or triple conversion. With xx-cm or wp-cm the conversion should be correct.
Game colors might be different with and without passthrough. Probably less saturated without passthrough. It might be the intended look but I don't like it. Hard to tell what is wrong and why.
render:cm_auto_hdr=2 might be better or worse depending on EDID correctness.

@LionHeartP

Copy link
Copy Markdown
Contributor

Well there's an open PR for Gamescope to switch over to upstream CM protocol, so I'm expecting this to be a non issue sooner rather than later.

vaxerski
vaxerski previously approved these changes Apr 29, 2025
@ryzendew

Copy link
Copy Markdown

Could this be updated so i can test it out

UjinT34 added a commit to UjinT34/hyprland-wiki that referenced this pull request May 28, 2025
@UjinT34 UjinT34 mentioned this pull request Jun 5, 2025
68 tasks

@vaxerski vaxerski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wiki mr needed

UjinT34 added a commit to UjinT34/hyprland-wiki that referenced this pull request Jun 22, 2025
@vaxerski vaxerski merged commit cf7e3aa into hyprwm:main Jun 23, 2025
12 checks passed
vaxerski pushed a commit to hyprwm/hyprland-wiki that referenced this pull request Jun 23, 2025
fufexan pushed a commit to fufexan/Hyprland that referenced this pull request Jun 26, 2025
crthpl pushed a commit to crthpl/Hyprland that referenced this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants