protocols: Don't update hdr metadata if image description is unchanged#9776
Conversation
vaxerski
left a comment
There was a problem hiding this comment.
looks reasonable to me, but I'll wait for ujin's input
|
lgtm Won't help if client keeps spamming different image descriptions. Might happen to gamescope with mangohud. Looks like it alternates between the game and mangohud layer but always ends up with the same description. If something throws it off then it may result in non-working hdr or constant sdr - hdr switching. |
|
I think the different settings are on different subsurfaces so it's fine. It at least fixed the issue for the user who reported it and whose logs we've been looking at. There might be a second issue of how to deal with multiple subsurfaces but this at least fixes the performance part. |
|
Describe your PR, what does it fix/add?
Gamescope sends a new frog color management protocol
set_render_intent,set_known_container_color_volume, andset_known_transfer_functionevery commit. Previously, this would trigger a modeset every commit, despite the new image description being equal to the old image description.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I'm not familiar with color management so it might be good to get @UjinT34's review, but this PR does fix the issue for the user who reported it on Discord.
Is it ready for merging, or does it need work?
Ready for merging