Better support "xet-write-token" API authorization model and LFS Batch Api change#498
Merged
Better support "xet-write-token" API authorization model and LFS Batch Api change#498
Conversation
assafvayner
reviewed
Sep 22, 2025
…equests and cas requests
sirahd
approved these changes
Sep 23, 2025
assafvayner
approved these changes
Sep 23, 2025
seanses
added a commit
that referenced
this pull request
Sep 23, 2025
According to PR feedback #498 (comment), move error constructors into the enum impls.
LFS Batch Api response is updated in huggingface-internal/moon-landing#15121 that - makes token refresh route mandatory (in field `action.href`) and puts CAS URL in the headers map; - sends a session id in the headers map; This PR builds on top of #498 and updates how client uses the information according to the above changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients can get a xet write token, if
Fixed a bug when getting the current branch name in a repo, which didn't parse branch names with "/" correctly: change
refs_heads_branch.rsplit('/').next()torefs_heads_branch.strip_prefix("refs/heads/").Also updated xet transfer agent to use the refresh route in the LFS Batch Api response.
Use the session id in the LFS Batch Api response for token refresh and CAS requests.