Skip to content

Update in accordance with LFS Batch Api change#506

Merged
seanses merged 4 commits intodi/use-refresh-route-if-existsfrom
di/update-git-xet-api
Sep 23, 2025
Merged

Update in accordance with LFS Batch Api change#506
seanses merged 4 commits intodi/use-refresh-route-if-existsfrom
di/update-git-xet-api

Conversation

@seanses
Copy link
Collaborator

@seanses seanses commented Sep 23, 2025

LFS Batch Api response is updated in https://github.com/huggingface-internal/moon-landing/pull/15121 that

  • makes token refresh route mandatory (in field action.href) and puts CAS URL in the headers map;
  • sends a session id in the headers map;

This PR builds on top of #498 and updates how client uses the information according to the above changes.

@seanses seanses changed the base branch from main to di/use-refresh-route-if-exists September 23, 2025 14:00
@seanses seanses force-pushed the di/update-git-xet-api branch from 7e70acf to 9d42089 Compare September 23, 2025 14:03
@seanses seanses marked this pull request as ready for review September 23, 2025 14:09
@seanses seanses changed the title Update in accordance with of LFS Batch Api change Update in accordance with LFS Batch Api change Sep 23, 2025
@seanses seanses requested a review from sirahd September 23, 2025 21:34
Copy link
Collaborator

@rajatarya rajatarya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Couldn't test locally, am assuming you've tested this.

According to PR feedback
#498 (comment),
move error constructors into the enum impls.
@seanses seanses merged commit 021c011 into di/use-refresh-route-if-exists Sep 23, 2025
6 checks passed
@seanses seanses deleted the di/update-git-xet-api branch September 23, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants