Track total processed bytes and total transferred bytes#328
Merged
Conversation
84e5b36 to
2e888c6
Compare
This was referenced May 15, 2025
assafvayner
added a commit
that referenced
this pull request
May 15, 2025
fix XET-567 This PR adds the retry mechanism on downloading a range from CF/S3 for when an error occurs reading or parsing the body. The upload is handled by reverting a change to reintroduce retries on a clonable body PR #328.
381e82a to
30f141d
Compare
assafvayner
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With deduplication, just tracking the total processed bytes can give a false impression of actual progress when uploading files; the user would often see a huge jump when hitting a deduplicated part. This PR allows us to report bytes uploaded or downloaded separately from the bytes processed, which would allow us to correctly surface network utilization.
For example, one possible way to show this would be: