add retries on body read errors during download#331
Merged
assafvayner merged 3 commits intomainfrom May 15, 2025
Merged
Conversation
seanses
reviewed
May 15, 2025
|
|
||
| impl tokio_retry::Condition<CasClientError> for ChunkRangeDeserializeFromBytesStreamRetryCondition { | ||
| fn should_retry(&mut self, err: &CasClientError) -> bool { | ||
| // we only care about retrying some error yielded by trying to deserialize the stream |
Collaborator
There was a problem hiding this comment.
This can't handle this case: huggingface/huggingface_hub#3036 (comment), which comes from send()
Contributor
Author
There was a problem hiding this comment.
that should be handled by the retry middleware on the client
Collaborator
There was a problem hiding this comment.
Hmm.. The message says kind: Request and the implementation on Request kind is only to retry on hyper_error.is_incomplete_message() || hyper_error.is_canceled() or if the underlying I/O error is std::io::ErrorKind::ConnectionReset | std::io::ErrorKind::ConnectionAborted, but not including hyper::Error(ChannelClosed)
seanses
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix XET-567
This PR adds the retry mechanism on downloading a range from CF/S3 for when an error occurs reading or parsing the body.
The upload is handled by reverting a change to reintroduce retries on a clonable body PR #328.