Adapt and test huggingface_hub v1.0.0#40889
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
The following failure is related (see below)
Is The same failure happens many times in the job |
are also related to this PR. |
This pass when I ssh into a CircleCI runner. Could ignore for now and will check later |
|
There are some
for example
But I'm not able to reproduce when I ssh into a CircleCI runner. Could check later. |
|
There are some failing tests (in the complete CI runs) that seems irrelevant at a first glance but actually related surprisingly.
fails with 1.0 rc but pass with 0.35. Add same for
|
also fails with this PR |
same error as the first and second one |
|
if you need to see the job run pages https://github.com/huggingface/transformers/actions/runs/17923228517/job/50963407968 |
* Adapt and test huggingface_hub v1.0.0.rc0 * forgot to bump hfh * bump * code quality * code quality * relax dependency table * fix has_file * install hfh 1.0.0.rc0 in circle ci jobs * repostiryo * push to hub now returns a commit url * catch HfHubHTTPError * check commit on branch * add it back * fix ? * remove deprecated test * uncomment another test * trigger * no proxies * many more small changes * fix load PIL Image from httpx * require 1.0.0.rc0 * fix mocked tests * fix others * unchange * unchange * args * Update .circleci/config.yml --------- Co-authored-by: Wauplin <lucainp@gmail.com>
|
The CI (circleci) against python 3.10 is fine 🎉 |
…ngface/transformers into ci-test-huggingface-hub-v1.0.0.rc0
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto |
ydshieh
left a comment
There was a problem hiding this comment.
CI looks fine:
- On CircleCI, they pass both on python 3.9 and now 3.10
- on Github Actions (daily scheduled CI), there are only 13 new failing tests compared to a previous run (of the same commit) on the
mainbranch, and they look irrelevant.
The PR is ready to be merged to main 🚀 Let's go
|
Yay! thanks for confirming! 🎉 I will work on the remaining TODOs in separate PRs. |
* Adapt and test huggingface_hub v1.0.0.rc0 * forgot to bump hfh * bump * code quality * code quality * relax dependency table * fix has_file * install hfh 1.0.0.rc0 in circle ci jobs * repostiryo * push to hub now returns a commit url * catch HfHubHTTPError * check commit on branch * add it back * fix ? * remove deprecated test * uncomment another test * trigger * no proxies * many more small changes * fix load PIL Image from httpx * require 1.0.0.rc0 * fix mocked tests * fix others * unchange * unchange * args * Update .circleci/config.yml * Bump to 1.0.0.rc1 * bump kernels version * fix deps
* Adapt and test huggingface_hub v1.0.0.rc0 * forgot to bump hfh * bump * code quality * code quality * relax dependency table * fix has_file * install hfh 1.0.0.rc0 in circle ci jobs * repostiryo * push to hub now returns a commit url * catch HfHubHTTPError * check commit on branch * add it back * fix ? * remove deprecated test * uncomment another test * trigger * no proxies * many more small changes * fix load PIL Image from httpx * require 1.0.0.rc0 * fix mocked tests * fix others * unchange * unchange * args * Update .circleci/config.yml * Bump to 1.0.0.rc1 * bump kernels version * fix deps
* Adapt and test huggingface_hub v1.0.0.rc0 * forgot to bump hfh * bump * code quality * code quality * relax dependency table * fix has_file * install hfh 1.0.0.rc0 in circle ci jobs * repostiryo * push to hub now returns a commit url * catch HfHubHTTPError * check commit on branch * add it back * fix ? * remove deprecated test * uncomment another test * trigger * no proxies * many more small changes * fix load PIL Image from httpx * require 1.0.0.rc0 * fix mocked tests * fix others * unchange * unchange * args * Update .circleci/config.yml * Bump to 1.0.0.rc1 * bump kernels version * fix deps
Test as part of huggingface/huggingface_hub#3340
The main changes in
huggingface_hubimpacting transformers are:RepositoryremovedHfFolderremovedhttpxinstead ofrequestsList of changes made in this PR:
# for backward compatibilityrequestsexceptions byhttpxones in testing utilsTrainerreturns aCommitInfo(which is a subclass ofstr) => was already the case before but not type annotatedallow_redirects=> renamedfollow_redirectsin httpxproxies=> argument is now ignored. Proxies must be set globally via env variable, not in script. If user passes a proxies, a warning is emitted and the process continues (ignoring the proxy)requests.HTTPErrorare replaced by somehuggingface_hub.HfHubHTTPError(which inherits fromhttpx.HTTPError)test_dynamic_saving_from_local_repoas it was commented as "# to be removed when huggingface_hub v1 comes out"HfFolderoccurrences from the tests => they were not relevant anywaysnapshot_downloadand "Repository push_to_hub" byupload_folderModelFilterfromutils/update_tiny_models.py(to be fair it has been removed since quite some time so this script is currently broken onmain)requests.getintohttpx.getin the code. However:requestscalls is happening in./models/andtest_models/so I won't change them => it'd be good intransformersv5 to get rid ofrequestsdependency entirely => also out of scope for this PRTODO: (later?)
utils/create_dummy_models.py=> currently usingRepository[cleanup] Don't use Repository in create_dummy_models.py script #42380remove back manual install of huggingface_hub 1.0.0.rc0 oncetokenizersis outwhat to do with KerasCallback? => got deleteduse_auth_tokenlogic must be removed (currently throws warnings) Remove deprecateduse_auth_tokenparameter #41666