Remove deprecated use_auth_token parameter#41666
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
left a comment
There was a problem hiding this comment.
Nice! Thanks a lot, happy to remove!
|
Can someone merge this one? I feel that the only failing test is not related to my PR 😃 (cc @ydshieh ?) |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto, bark, clvp, qwen2_5_omni, wav2vec2 |
|
@Wauplin I can't merge as the CI is red: jobs have crashing worker. Could you verify if those are caused by your PR? |
|
Arg, the CI from yesterday's commit worked perfectly fine, except for the test I mentioned. Now that I rebased from main it seems that all tests are crashing. I suspect this is not due to my PR but that it's also failing on |
|
it's torchcodec issue, sorry. I will built the new docker images and push |
* Remove deprecated use_auth_token * code styl * fix test * Update examples/pytorch/speech-recognition/README.md
* Remove deprecated use_auth_token * code styl * fix test * Update examples/pytorch/speech-recognition/README.md
* Remove deprecated use_auth_token * code styl * fix test * Update examples/pytorch/speech-recognition/README.md
use_auth_tokenparameter has been deprecated for a very long time (2 years?) and will be completely removed fromhuggingface_hubin v1.0.I think
transformersv5 is a perfect timing to also remove it from this library. In practice there has been a deprecation cycle for a long time (with bothtokenanduse_auth_tokenbeing accepted) so friction should be minimal.(cc @hanouticelina)