Merged
Conversation
amyeroberts
approved these changes
Sep 6, 2023
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
LGTM - thanks for fixing!
Rocketknight1
approved these changes
Sep 6, 2023
Member
Rocketknight1
left a comment
There was a problem hiding this comment.
Looks clean! I totally overlooked this as well - I should have scrolled down a few lines below the diff when I was reviewing.
ArthurZucker
approved these changes
Sep 6, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Missed this when reviewing! Thanks 🤗
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
LysandreJik
added a commit
that referenced
this pull request
Sep 15, 2023
* Fix revision propagation * Cleaner
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* Fix revision propagation * Cleaner
LysandreJik
added a commit
that referenced
this pull request
Sep 28, 2023
This reverts commit 118c676.
LysandreJik
added a commit
that referenced
this pull request
Oct 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revision should be kept in the kwargs as these are being propagated throughout the method afterwards.