Merged
Conversation
Rocketknight1
approved these changes
Sep 4, 2023
Member
Rocketknight1
left a comment
There was a problem hiding this comment.
LGTM! This kind of shimming makes me nervous, especially in auto_factory, but I can't see any bugs in the code so I think we'll get away with it for one version.
🦅
🏋️
|
The documentation is not available anymore as the PR was closed or merged. |
amyeroberts
approved these changes
Sep 4, 2023
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
LGTM - thanks for adding the code to handle this!
ArthurZucker
approved these changes
Sep 4, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Looks good to me !
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
9645500 to
11bab14
Compare
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* Put Falcon back * Update src/transformers/models/auto/configuration_auto.py Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com> * Update test --------- Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
LysandreJik
added a commit
that referenced
this pull request
Sep 28, 2023
This reverts commit 22a69f1.
LysandreJik
added a commit
that referenced
this pull request
Oct 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes hand in hand with #25954
As seen offline with @ArthurZucker but would still like additional eyes on this as it's touching critical code (that I'd honestly rather not be touching, but I don't see another way around it).
This code will be removed as soon as we can revert the change on the Falcon repositories as
from_pretrainedwill then automatically download the appropriate revision.