[from_pretrained] Fix failing PEFT tests#25733
Merged
younesbelkada merged 1 commit intohuggingface:mainfrom Aug 24, 2023
Merged
[from_pretrained] Fix failing PEFT tests#25733younesbelkada merged 1 commit intohuggingface:mainfrom
from_pretrained] Fix failing PEFT tests#25733younesbelkada merged 1 commit intohuggingface:mainfrom
Conversation
ArthurZucker
approved these changes
Aug 24, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Ouch I think it's a typo from merging see here
Collaborator
|
Let's make them not slow otherwise we are shooting in the dark 😉 |
Contributor
Author
|
The documentation is not available anymore as the PR was closed or merged. |
Collaborator
|
We can have a new job to see how long it takes. I would try to keep the new job to run only the PEFT tests but not to re-run the Let's hear our @sgugger 's wisdom too. We will miss it. |
Contributor
Author
|
Merging as this is blocking for an upcoming PR #25738 , will address future comments in a follow up PR! |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
fix failing PEFT tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses: #25726 (comment)
In fact it is important to overwrite
pretrained_model_name_or_pathwith thebase_model_name_or_pathattribute of the adapter config otherwisefrom_pretrainedwill try to load the config file from the adapter model_id where it should look for it atbase_model_name_or_pathnow all PEFT tests are green
cc @sgugger @ArthurZucker