[PEFT] Fix PeftConfig save pretrained when calling add_adapter#25738
Merged
younesbelkada merged 2 commits intohuggingface:mainfrom Aug 25, 2023
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
approved these changes
Aug 25, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks for catching this! 🔥
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
…uggingface#25738) fix save_pretrained issue + add test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a tiny issue when building a demo for @NielsRogge in huggingface/peft#796
when attaching a fresh new adapter, we need to manually add the attribute
base_model_name_or_pathotherwise we can't load back the base model.We did not flagged it before in the tests because we were only testing the case when we call
load_adapterthensave_pretrainedwhich works fine because we attach an existing PeftConfig.Added also a nice test
cc @ArthurZucker @sgugger