Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
amyeroberts
approved these changes
May 12, 2023
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for updating!
Given we're fixing TF and PT versions here, I'm assuming this is fine. I just have a question about future support - do we make any promises about maintaining support for cu117?
Collaborator
Author
|
We have the so called past CI which runs previous torch and tensorflow versions together the environment we set for them. In this particular case, since torch version is not changed but using cu118 file, we don't really have any extra CI for torch 2.0 with cu117 after this PR. So no real promise. But this is already the case for our CI, we always fix a cuda and cudnn environment until we really have to change 🙂 |
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We use TF 2.12 after #22759 and #23293. But TF 2.12 requires CUDA 11.8 and CUDNN 8.6 (or up) to work.
Currently, our CI have errors with
This PR uses new base image for some docker files. We also have to use
cu118for the torch installation with this new base image.Other docker files (those with deepspeed stuff) are not changed in this PR - better to see what happens with this change and apply to other files.
Running some previous failing tests and they pass now. Still need to watch if the whole suite (doctest) pass on Monday.