Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
amyeroberts
approved these changes
May 11, 2023
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
LGTM - thanks for updating!
ydshieh
commented
May 11, 2023
|
|
||
| # If set to nothing, will install the latest version | ||
| ARG PYTORCH='2.0.0' | ||
| ARG PYTORCH='2.0.1' |
Collaborator
Author
There was a problem hiding this comment.
Let's use the latest version. Otherwise, while building the docker image using this docker file, there will be other version conflicts during build and cause the image being too large and ran out of the disk.
ydshieh
commented
May 11, 2023
Comment on lines
-39
to
-43
| # To include the change in this commit https://github.com/onnx/tensorflow-onnx/commit/ddca3a5eb2d912f20fe7e0568dd1a3013aee9fa3 | ||
| # Otherwise, we get tf2onnx==1.8 (caused by `flatbuffers` version), and some tests fail with `ValueError: from_keras requires input_signature`. | ||
| # TODO: remove this line once the conflict is resolved in these libraries. | ||
| RUN python3 -m pip install --no-cache-dir git+https://github.com/onnx/tensorflow-onnx.git@ddca3a5eb2d912f20fe7e0568dd1a3013aee9fa3 | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Remove this as this causes protobuf to be downgraded to < 2.20.3. We will see if the new tensorflow-onnx will cause other problems.
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
* unpin tf prob --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* unpin tf prob --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
unpin tf prob