Conversation
require_torch to 2 pipeline tests
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Dec 5, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Sorry I broke those, thanks for fixing!
mpierrau
pushed a commit
to mpierrau/transformers
that referenced
this pull request
Dec 15, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The 2 tests are for
pytorch, but in TF pipeline test CI job (wheretorchis not available), it runs with TF models.This is not expected.
Before #20149, these 2 tests are decorated with
require_torch_scatter. After that PR, the tests try to run with TF, but failed withTFTapasMainLayer requires the tensorflow_probability library but it was not found in your environment.(this is another thing to fix in docker file)