Fix tapas scatter#20149
Fix tapas scatter#20149sgugger merged 9 commits intohuggingface:mainfrom Bearnardd:fix_tapas_scatter_2
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
NielsRogge
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing!
Could you also remove all "scatter" mentions in the code base? https://github.com/search?q=repo%3Ahuggingface%2Ftransformers%20scatter&type=code
ydshieh
left a comment
There was a problem hiding this comment.
Thank you again, @Bearnardd !
sgugger
left a comment
There was a problem hiding this comment.
Thanks a lot for migrating to PyTorch!
Could you just remove the file src/transformers/utils/dummy_scatter_objects.py as it won't be necessary anymore.
|
Hi @sgugger - Sure, I will remove it as a part of removing all "scatter" mentions requested by @NielsRogge. |
|
Hi @NielsRogge - could you tell me what is the difference between |
|
Good question, you can remove both ;) |
|
@NielsRogge - I have removed "scatter" mentions from the code base. It will be good to double check the changes :). I have not changed |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
Thanks for all the work! Will rebase my PR on yours to finish the job :-) |
* First draft * Remove scatter dependency * Add require_torch * update vectorized sum test, add clone call * remove artifacts * fix style * fix style v2 * remove "scatter" mentions from the code base * fix isort error Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local> Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
What does this PR do?
Changes the usage of scatter from torch_scatter to PyTorch's scatter thus removing the dependency on third party library
_segment_reducefunction in order to work with PyTorch's scattertest_reduce_sum_vectorizedFixes # (issue)
#20101
Who can review?
@NielsRogge