Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Collaborator
Contributor
|
Hi @sgugger :) - One question, you have removed |
Collaborator
Author
|
The scatter dependency is only removed from the CPU runners on circleCI, it's not removed from the library byt his PR, that's your job ;-) . When testing in our other setups that include the |
f782f66 to
d1cfa8c
Compare
mpierrau
pushed a commit
to mpierrau/transformers
that referenced
this pull request
Dec 15, 2022
* Try PT1.13 by removing torch scatter * Skip failing tests * Style * Remvoe testing extras for repo utils * Try with all decorators * Try to wipe the cache * Fix all tests? * Try this way * Fix comma * Update to main * Try with less deps * Quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables PyTorch 1.13 for Transformers so we can start adding functionality like safer loading with
torch.load. Since there are no wheels for torch scatter, this comes at the price of uninstallingtorch-scatter. However the PR to move away from this dep and use the PyTorch core ops seems well under way, so skipping the TAPAS tests for now until the PR is merged does not seem like a heavy price to pay (cc @NielsRogge for information).A couple of tests are still failing, which are all torch FX tests (cc @michaelbenayoun, see failing job here). I'm skipping them and we can fix them next week in a followup PR.