[ViT, BEiT, DeiT, DPT] Improve code#16799
Merged
LysandreJik merged 5 commits intohuggingface:mainfrom Apr 18, 2022
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Apr 15, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
added 2 commits
April 15, 2022 14:16
LysandreJik
approved these changes
Apr 18, 2022
Member
LysandreJik
left a comment
There was a problem hiding this comment.
LGTM, thanks @NielsRogge!
Merged
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* Improve code * Fix bugs * Fix another bug * Clean up DTP as well * Update DPT model outputs Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR cleans up some code of ViT, BEiT, DeiT and DPT.
Most importantly, it corrects the tuple outputs, in case no pooler was added (as shown by #16760).
Next to that, it cleans up the tests, by
to_2tuple, and instead leveraging anexpected_seq_lenattribute of theModelTesterchunk_lengthandis_encoder_decoderstatements, which don't apply for these encoder-only models.