[Data2Vec] Add data2vec vision#16760
Merged
patrickvonplaten merged 29 commits intohuggingface:mainfrom Apr 18, 2022
Merged
Conversation
…to add_data2vec_vision
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
Uploaded checkpoints are here: https://huggingface.co/models?other=data2vec-vision . Will add a README to those ones and all other data2vec ones after this PR is merged |
sgugger
approved these changes
Apr 14, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Thanks for adding this new model!
NielsRogge
reviewed
Apr 15, 2022
NielsRogge
reviewed
Apr 15, 2022
src/transformers/models/data2vec/configuration_data2vec_vision.py
Outdated
Show resolved
Hide resolved
NielsRogge
reviewed
Apr 15, 2022
src/transformers/models/data2vec/configuration_data2vec_vision.py
Outdated
Show resolved
Hide resolved
NielsRogge
reviewed
Apr 15, 2022
NielsRogge
reviewed
Apr 15, 2022
NielsRogge
reviewed
Apr 15, 2022
NielsRogge
reviewed
Apr 15, 2022
NielsRogge
reviewed
Apr 15, 2022
NielsRogge
reviewed
Apr 15, 2022
NielsRogge
approved these changes
Apr 15, 2022
Contributor
NielsRogge
left a comment
There was a problem hiding this comment.
Thanks for adding! My only comment is about some additional copied from statements, if possible.
NielsRogge
reviewed
Apr 15, 2022
src/transformers/models/data2vec/configuration_data2vec_vision.py
Outdated
Show resolved
Hide resolved
Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com> Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com>
…to add_data2vec_vision
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* save intermediate * add vision * add vision * save * finish models * finish models * continue * finish * up * up * up * tests all pass * clean up * up * up * fix bugs in beit * correct docs * finish * finish docs * make style * up * more fixes * fix type hint * make style * Apply suggestions from code review Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com> Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Update tests/data2vec/test_modeling_data2vec_vision.py Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com> * fix test Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com> Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Finishes the Data2Vec integration by adding https://huggingface.co/models?other=data2vec-vision from https://github.com/facebookresearch/data2vec_vision/tree/main/beit
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.