Skip to content

Make text body narrower for readability#353

Merged
mnot merged 1 commit intomasterfrom
mnot-htmlwidth
Apr 28, 2020
Merged

Make text body narrower for readability#353
mnot merged 1 commit intomasterfrom
mnot-htmlwidth

Conversation

@mnot
Copy link
Copy Markdown
Member

@mnot mnot commented Mar 23, 2020

Currently we have about 110+ characters per line;
broadly accepted norms for readability are 55-65.

This takes it to about 85.

Currently we have about 110+ characters per line;
broadly accepted norms for readability are 55-65.

This takes it to about 85.
@mnot mnot requested a review from reschke March 23, 2020 04:17
@martinthomson
Copy link
Copy Markdown
Contributor

I tested this out and the rule on pre.text, pre.text2 is width: 69em. That is 993.6px for me, which looks really odd. You could almost miss it with a wider page, but it really sticks out now. I'd recommend going to:

pre.text, pre.text2 {
  width: 100%;
  width: calc(100% - 3.5em - 2px);
}

That would allow for the extra margin, border, and padding on the element.

@reschke
Copy link
Copy Markdown
Contributor

reschke commented Mar 23, 2020

The purpose here is that the width reflects what can go inside artwork, not to scale it according to the page width. After all, we're not breaking lines here.

I'm not happy with what I have here as the width computation is excessive; but something like that will need to stay.

@martinthomson
Copy link
Copy Markdown
Contributor

martinthomson commented Mar 23, 2020

So with the font size you have, 69em is way too much space. Assuming 72 characters is your goal, you can go down to 44em or 625px (though slightly more is better). See http://fellowhuman.com/blog/2015/06/09/monospaced-fonts-and-column-units/ for more info on what an em is.

Copy link
Copy Markdown
Member

@royfielding royfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have an opinion unless it causes a weird line-wrap in examples.

@reschke
Copy link
Copy Markdown
Contributor

reschke commented Apr 2, 2020

@martinthomson - thanks for the link; will have a look.

It seems I can simply switch to "69ch" (ignoring IE compat). What do you think?

Copy link
Copy Markdown
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree, but I won't stand in your way :-)

@mnot
Copy link
Copy Markdown
Member Author

mnot commented Apr 27, 2020

@martinthomson you want to make some modifications?

@martinthomson
Copy link
Copy Markdown
Contributor

It appears as though Julian has fixed the pre.text rule in the main stylesheet, which is what would be needed. So this should be good to go.

@mnot mnot merged commit 9885adf into master Apr 28, 2020
@mnot mnot deleted the mnot-htmlwidth branch April 28, 2020 00:48
triple-underscore added a commit to triple-underscore/triple-underscore.github.io that referenced this pull request Apr 29, 2020
httpwg/http-core#343
• Adjust multiple Content-Length handling

httpwg/http-core#346
• Rework invalidation definition
• Roy's suggestions
• grammar

httpwg/http-core#353
• Make text body narrower for readability

httpwg/http-core#354
• Remove H1-specific connection-related requirements
• Roy's feedback

httpwg/http-core#316
• map request target to target URI/resource
• fix one leftover of "effective request URI"
• Adjust anchor names
• push note into <aside> and move index entry
• sort change log
• restore indentation
• re-add missing closing brackets
• fix change log section title
• fix change log
• remove semantics HTML too
• removing HTML from PR

httpwg/http-core#344
• Don't rely on the HTTP/1.1 Messaging specification to define "message"

httpwg/http-core#357
• Present If-[none]-Match evaluation more clearly

httpwg/http-core#72
• Semantics of If-Match

httpwg/http-core#345
• remove ref to close option
• remove HTML from PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants