Merged
Conversation
a12197b to
92e685b
Compare
Contributor
Author
|
cc: @keithamus |
seanpdoyle
commented
Jun 23, 2022
| } | ||
|
|
||
| export function nextBody(_page: Page, timeout = 500) { | ||
| return sleep(timeout) |
Contributor
Author
There was a problem hiding this comment.
@keithamus this is one of the bigger hurdles for the migration. The old version tracked the <body> element with instance state. Since playwright test blocks have no context, I'm not sure of the best way to synchronize on a change.
b92703b to
83a280e
Compare
Replaces the [intern][]-powered functional test suite with one powered
by [playwright][].
The majority of the changes made aim to preserve the structure and
method names of the original `intern` suite. There are some
out-of-the-box Playwright features that could replace many of our
bespoke helpers, but that work should be done after the migration.
As a result, the majority of the changes involve a combination of:
* replacing `async "test ..."() { ... }` with `test("test ...", async
({ page }) => { ... }`
* replacing calls in the style of `this.methodName` with calls in the
style of `methodName(page)`
In some cases, exceptions were made. For example, most calls to
`this.clickSelector` were replaced with calls to [page.click][].
The unit test suite
---
Playwright's focus on a browser-powered test harness make it an odd fit
for our small suite of "unit" tests. Unlike their browser-test
counterparts, the unit tests do not have a history of flakiness.
This changeset defers migrating those tests off of `intern` for a later
batch of work.
[intern]: https://theintern.io
[playwright]: https://playwright.dev
[page.click]: https://playwright.dev/docs/api/class-page#page-click
dhh
pushed a commit
to seanpdoyle/turbo
that referenced
this pull request
Jul 15, 2022
* main: Drive Browser tests with `playwright` (hotwired#609) Allow Turbo Streams w/ GET via `data-turbo-stream` (hotwired#612) Only update history when Turbo visit is renderable (hotwired#601) Support development ChromeDriver version overrides (hotwired#606) Turbo stream source (hotwired#415) Expose Frame load state via `[complete]` attribute (hotwired#487)
dhh
pushed a commit
to feliperaul/turbo
that referenced
this pull request
Jul 16, 2022
* main: Allow frames to scroll smoothly into view (hotwired#607) Export Type declarations for `turbo:` events (hotwired#452) Add .php as a valid isHTML extension (hotwired#629) Add original click event to 'turbo:click' details (hotwired#611) Drive Browser tests with `playwright` (hotwired#609) Allow Turbo Streams w/ GET via `data-turbo-stream` (hotwired#612) Only update history when Turbo visit is renderable (hotwired#601) Support development ChromeDriver version overrides (hotwired#606) Turbo stream source (hotwired#415) Expose Frame load state via `[complete]` attribute (hotwired#487) fix(ie/edge): form.method='delete', raises Invalid argument. (hotwired#586) Do not declare global types/constants (hotwired#524) Defensively create custom turbo elements (hotwired#483) Use `replaceChildren` in StreamActions.update (hotwired#534)
cvkef
added a commit
to cvkef/turbo
that referenced
this pull request
Oct 19, 2022
This commit moves the minimum required `node` version under a `devEngines` section at the `package.json`. The introduction of the [playwright][] test suite forced the minimum required `node` version to v14. As a side effect, using the `engines` section of the `package.json` to set this dependency, introduces an unreasonable constraint to use the `turbo` library in other projects. Considering that `playwright` is a development only dependency, it seems justified to keep it under a `devEngines` section of the `package.json`. [playwright]: hotwired#609
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the intern-powered functional test suite with one powered
by playwright.
The majority of the changes made aim to preserve the structure and
method names of the original
internsuite. There are someout-of-the-box Playwright features that could replace many of our
bespoke helpers, but that work should be done after the migration.
As a result, the majority of the changes involve a combination of:
async "test ..."() { ... }withtest("test ...", async ({ page }) => { ... }this.methodNamewith calls in thestyle of
methodName(page)In some cases, exceptions were made. For example, most calls to
this.clickSelectorwere replaced with calls to page.click.The unit test suite
Playwright's focus on a browser-powered test harness make it an odd fit
for our small suite of "unit" tests. Unlike their browser-test
counterparts, the unit tests do not have a history of flakiness.
This changeset defers migrating those tests off of
internfor a laterbatch of work.