Skip to content

Allow frames to scroll smoothly into view#607

Merged
dhh merged 1 commit intohotwired:mainfrom
npezza93:smooth-scroll
Jul 15, 2022
Merged

Allow frames to scroll smoothly into view#607
dhh merged 1 commit intohotwired:mainfrom
npezza93:smooth-scroll

Conversation

@npezza93
Copy link
Copy Markdown
Contributor

The default behavior can be pretty jarring depending on your use case but this allows people to specify the scroll behavior when autoscrolling.

@dhh
Copy link
Copy Markdown
Member

dhh commented Jul 15, 2022

Great! Could you add a doc PR as well to hotwired/turbo-site we can merge on 7.2.0 release?

@dhh dhh merged commit 39fe418 into hotwired:main Jul 15, 2022
dhh pushed a commit to feliperaul/turbo that referenced this pull request Jul 16, 2022
* main:
  Allow frames to scroll smoothly into view (hotwired#607)
  Export Type declarations for `turbo:` events (hotwired#452)
  Add .php as a valid isHTML extension (hotwired#629)
  Add original click event to 'turbo:click' details (hotwired#611)
  Drive Browser tests with `playwright` (hotwired#609)
  Allow Turbo Streams w/ GET via `data-turbo-stream` (hotwired#612)
  Only update history when Turbo visit is renderable (hotwired#601)
  Support development ChromeDriver version overrides (hotwired#606)
  Turbo stream source (hotwired#415)
  Expose Frame load state via `[complete]` attribute (hotwired#487)
  fix(ie/edge): form.method='delete', raises Invalid argument. (hotwired#586)
  Do not declare global types/constants (hotwired#524)
  Defensively create custom turbo elements (hotwired#483)
  Use `replaceChildren` in StreamActions.update (hotwired#534)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants