Conversation
yusukebe
commented
Mar 9, 2026
Member
Author
There was a problem hiding this comment.
Running bun install in the local added "configVersion": 0.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4798 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 177 177
Lines 11623 11623
Branches 3461 3461
=======================================
Hits 10790 10790
Misses 832 832
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Hey @BarryThePenguin ! The CI fails. How about specifying diff --git a/.github/actions/perf-measures/action.yml b/.github/actions/perf-measures/action.yml
index 69e35fca..252dc67e 100644
--- a/.github/actions/perf-measures/action.yml
+++ b/.github/actions/perf-measures/action.yml
@@ -16,7 +16,7 @@ runs:
bun-version-file: '.tool-versions'
- run: |
bun install --frozen-lockfile
- bun tsc --build
+ bun tsc --build tsconfig.build.json
shell: bash
- name: Performance measurement of type check (tsc) |
Co-authored-by: Jonathan Haines <jonno.haines@gmail.com>
Bundle size check
Compiler Diagnostics (tsc)
Compiler Diagnostics (typescript-go)
Reported by octocov |
HTTP Performance Benchmark
|
Member
Author
|
@BarryThePenguin Nice! Your fix is good. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #4797
Added
tsconfig.spec.jsonto enable type checks for test files.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code