Skip to content

chore(builld): tsconfig project references#4797

Merged
yusukebe merged 4 commits intohonojs:mainfrom
BarryThePenguin:chore/tsconfig-project-references
Mar 9, 2026
Merged

chore(builld): tsconfig project references#4797
yusukebe merged 4 commits intohonojs:mainfrom
BarryThePenguin:chore/tsconfig-project-references

Conversation

@BarryThePenguin
Copy link
Contributor

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

I had a go at adding Project References to the runtime tests. I noticed that there were a small number of TypeScript issues as the runtime integrations have changed over time. I've fixed the easy ones, and ignored the difficult ones 😅 Hopefully it will help prevent this in the future.

@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.83%. Comparing base (8217d9e) to head (c6a002b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4797      +/-   ##
==========================================
+ Coverage   91.58%   92.83%   +1.24%     
==========================================
  Files         177      177              
  Lines       11799    11623     -176     
  Branches     3459     3462       +3     
==========================================
- Hits        10806    10790      -16     
+ Misses        992      832     -160     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Mar 9, 2026

@BarryThePenguin

Thanks! This was what I wanted to do, but I could not touch it yet!

@yusukebe yusukebe merged commit d69deb8 into honojs:main Mar 9, 2026
20 checks passed
@yusukebe yusukebe mentioned this pull request Mar 9, 2026
4 tasks
@BarryThePenguin BarryThePenguin deleted the chore/tsconfig-project-references branch March 9, 2026 13:10
@BarryThePenguin
Copy link
Contributor Author

I'm glad it's useful 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants